----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64209/#review192335 -----------------------------------------------------------
Ship it! Can you provide some notes on the manual testing effort on this? - Sid Wagle On Nov. 30, 2017, 1:28 p.m., Andrew Onischuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64209/ > ----------------------------------------------------------- > > (Updated Nov. 30, 2017, 1:28 p.m.) > > > Review request for Ambari, Attila Doroszlai, Myroslav Papirkovskyy, Nate > Cole, and Sid Wagle. > > > Bugs: AMBARI-22561 > https://issues.apache.org/jira/browse/AMBARI-22561 > > > Repository: ambari > > > Description > ------- > > * User denies the GPL license agreement, UI will still issue PUT call to > create the repo > * Ambari should not write HDP-GPL repo info to the ambari-hdp-1.repo > because it will break yum in local repo world. > * Then the user accepts the license by running ambari-server setup > * The repo file does not get updated on existing hosts > * We need to push the HDP-GPL repo to the repo files on existing hosts only > when the license is accepted > > > Diffs > ----- > > > ambari-common/src/main/python/resource_management/libraries/functions/lzo_utils.py > 68ee607b9b > > ambari-common/src/main/python/resource_management/libraries/functions/repository_util.py > f1c8ef1b04 > > ambari-common/src/main/python/resource_management/libraries/script/script.py > ccb8a547f4 > > ambari-server/src/main/java/org/apache/ambari/server/agent/CommandRepository.java > e207ac5289 > ambari-server/src/main/resources/custom_actions/scripts/install_packages.py > b819dcad96 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/repo_initialization.py > 82e57aa4f4 > ambari-server/src/test/python/stacks/utils/RMFTestCase.py 80712c5ebe > > > Diff: https://reviews.apache.org/r/64209/diff/1/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Andrew Onischuk > >
