-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64315/#review192882
-----------------------------------------------------------


Ship it!




2 small nits


ambari-common/src/main/python/resource_management/libraries/functions/lzo_utils.py
Lines 60 (patched)
<https://reviews.apache.org/r/64315/#comment271215>

    you can just do:
    check_stack_feature(StackFeature.LZO, stack_version_unformatted)



ambari-common/src/main/python/resource_management/libraries/functions/lzo_utils.py
Lines 72 (patched)
<https://reviews.apache.org/r/64315/#comment271216>

    Maybe also logger.info "This stack does not indicate that it supports LZO 
installation"


- Jonathan Hurley


On Dec. 5, 2017, 11:51 a.m., Sid Wagle wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64315/
> -----------------------------------------------------------
> 
> (Updated Dec. 5, 2017, 11:51 a.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-22588
>     https://issues.apache.org/jira/browse/AMBARI-22588
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> IOP Migration: Hive Client restart fails: hadooplzo package not present in 
> iop repos
> 
> *STR*:
> - Install IOP-425 cluster
> - Now upgrade Ambari to 2.6.1. Hive client restart fails
> 
> {code}
> Cannot match package for regexp name hadooplzo_${stack_version}
> {code}
> 
> 
> Diffs
> -----
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/lzo_utils.py
>  68ee607 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.0/properties/stack_features.json
>  d29efb2 
> 
> 
> Diff: https://reviews.apache.org/r/64315/diff/2/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Sid Wagle
> 
>

Reply via email to