----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64388/#review193048 -----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListener.java Lines 132-133 (original), 140-141 (patched) <https://reviews.apache.org/r/64388/#comment271545> OK, so here's the issue - we're iterating over all host versions looking to see if any need to be marked as OUT_OF_SYNC. The case we're trying to cover here is whether FOO_COMPONENT is not advertised in HDP 2.4 and doesn't affect HDP 2.4 host versions. But instead, it affects HDP 2.5+ since it's advertised there. So I think skipping it with this is OK. However, you also missed it in the other method onServiceEvent(...) - Jonathan Hurley On Dec. 6, 2017, 1:52 p.m., Myroslav Papirkovskyy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64388/ > ----------------------------------------------------------- > > (Updated Dec. 6, 2017, 1:52 p.m.) > > > Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, and Sid Wagle. > > > Bugs: AMBARI-22605 > https://issues.apache.org/jira/browse/AMBARI-22605 > > > Repository: ambari > > > Description > ------- > > STR: > Deploy minimal cluster (HDFS, YARN+MR2, ZooKeeper). > Add Tez service. > Service check hangs for a long time. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java > 85e0c1cf130974377abb7b685f191e20324b090e > > ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListener.java > d5a1ac4fd06377a992a8286d6fca366536a25157 > > > Diff: https://reviews.apache.org/r/64388/diff/1/ > > > Testing > ------- > > mvn clean test > manual check > > > Thanks, > > Myroslav Papirkovskyy > >
