----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64411/#review193109 -----------------------------------------------------------
Ship it! Ship It! - Andrii Tkach On Dec. 7, 2017, 1:23 p.m., Andrii Babiichuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64411/ > ----------------------------------------------------------- > > (Updated Dec. 7, 2017, 1:23 p.m.) > > > Review request for Ambari and Andrii Tkach. > > > Bugs: AMBARI-22610 > https://issues.apache.org/jira/browse/AMBARI-22610 > > > Repository: ambari > > > Description > ------- > > 1. Search box typeahead shouldn't display dropdown with 'No Results Found' > text if there are no matches. > 2. Filtering by parameters from search box should be applied by pressing > Enter as well as by Search button click. > > > Diffs > ----- > > ambari-logsearch/ambari-logsearch-web/package.json 2c6aa8d > ambari-logsearch/ambari-logsearch-web/src/app/app.module.ts 5e43582 > ambari-logsearch/ambari-logsearch-web/src/app/classes/filtering.ts d92dd41 > > ambari-logsearch/ambari-logsearch-web/src/app/components/dropdown-list/dropdown-list.component.less > 674b195 > > ambari-logsearch/ambari-logsearch-web/src/app/components/filters-panel/filters-panel.component.html > 440efde > > ambari-logsearch/ambari-logsearch-web/src/app/components/filters-panel/filters-panel.component.ts > 1717bd7 > ambari-logsearch/ambari-logsearch-web/src/app/components/mixins.less > 0bf169d > > ambari-logsearch/ambari-logsearch-web/src/app/components/search-box/search-box.component.html > 5ab9a69 > > ambari-logsearch/ambari-logsearch-web/src/app/components/search-box/search-box.component.less > 9deea92 > > ambari-logsearch/ambari-logsearch-web/src/app/components/search-box/search-box.component.spec.ts > 72795a4 > > ambari-logsearch/ambari-logsearch-web/src/app/components/search-box/search-box.component.ts > 64b8c36 > > ambari-logsearch/ambari-logsearch-web/src/app/services/component-actions.service.ts > 0fc9fde > > ambari-logsearch/ambari-logsearch-web/src/app/services/logs-container.service.ts > 4adf577 > ambari-logsearch/ambari-logsearch-web/yarn.lock c005503 > > > Diff: https://reviews.apache.org/r/64411/diff/1/ > > > Testing > ------- > > Executed 216 of 216 SUCCESS (4.525 secs / 4.447 secs) > > > Thanks, > > Andrii Babiichuk > >
