-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64407/#review193119
-----------------------------------------------------------




ambari-server/src/main/python/ambari_server/serverSetup.py
Lines 1140-1141 (patched)
<https://reviews.apache.org/r/64407/#comment271623>

    Can this somehow be validated to the known, good os family values?  If not, 
this is still ok.



ambari-server/src/main/python/ambari_server/serverSetup.py
Lines 1199 (patched)
<https://reviews.apache.org/r/64407/#comment271622>

    nit: formatting (odd space)


- Nate Cole


On Dec. 7, 2017, 4:35 a.m., Sneha Kanekar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64407/
> -----------------------------------------------------------
> 
> (Updated Dec. 7, 2017, 4:35 a.m.)
> 
> 
> Review request for Ambari and Nate Cole.
> 
> 
> Bugs: AMBARI-22592
>     https://issues.apache.org/jira/browse/AMBARI-22592
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The ambari-server setup script is updated to allow the user to store/update 
> Ambari repo base URL in ambari.properties file for each OS type through 
> command line. The command to set Ambari repo URL : ambari-server setup 
> --ambari-repo <Ambari_Repo_URL>
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/python/ambari-server.py 188910e 
>   ambari-server/src/main/python/ambari_server/serverConfiguration.py f744fa0 
>   ambari-server/src/main/python/ambari_server/serverSetup.py af45584 
>   ambari-server/src/test/python/TestAmbariServer.py ad4e371 
> 
> 
> Diff: https://reviews.apache.org/r/64407/diff/1/
> 
> 
> Testing
> -------
> 
> Tests were successful in ambari-server.
> 
> 
> Thanks,
> 
> Sneha Kanekar
> 
>

Reply via email to