> On Dec. 11, 2017, 10:23 p.m., Madhuvanthi Radhakrishnan wrote: > > ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql > > Line 42 (original) > > <https://reviews.apache.org/r/64478/diff/1/?file=1911954#file1911954line42> > > > > Where are we setting this value? I saw we removed it from the > > StackManager code. So, in UI deployment it might fail. > > Balázs Bence Sári wrote: > Mistakenly left there. Will remove.
Hey Madhu, this column was added by me on the branch-feature-AMBARI-14714 branch. It turned out to be a mistake hence I am removing it. I don't think UI picked this property up yet. - Balázs Bence ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64478/#review193429 ----------------------------------------------------------- On Dec. 9, 2017, 12:19 p.m., Attila Doroszlai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64478/ > ----------------------------------------------------------- > > (Updated Dec. 9, 2017, 12:19 p.m.) > > > Review request for Ambari, Balázs Bence Sári, Jayush Luniya, Madhuvanthi > Radhakrishnan, Robert Nettleton, and Swapan Shridhar. > > > Bugs: AMBARI-22253, AMBARI-22297 and AMBARI-22325 > https://issues.apache.org/jira/browse/AMBARI-22253 > https://issues.apache.org/jira/browse/AMBARI-22297 > https://issues.apache.org/jira/browse/AMBARI-22325 > > > Repository: ambari > > > Description > ------- > > Implementation of Blueprint V2 API POST that allows cluster creation. > Co-authored by Balázs Bence Sári and Attila Doroszlai. > > Includes minor fixes for: > > * AMBARI-22196 -- yum repo file contains parsing errors due to initial > whitespace > * AMBARI-22249 -- AmbariContext.serviceGroupDependencyResourceProvider > initialization > * AMBARI-22164 -- wrong assignment due to leftover parameter name > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/ObjectNotFoundException.java > 75c9f3b5d50102f3beeeaa8041178cc08e22e241 > > ambari-server/src/main/java/org/apache/ambari/server/ParentObjectNotFoundException.java > 15bd7cb6bbe5026bf0a5ae9d3fc0bec575137643 > > ambari-server/src/main/java/org/apache/ambari/server/StackAccessException.java > b8bfff3991a4e49514801dbb480958941cff01ac > > ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java > fd43edfa88339cd94686ddc13822b36ab7c74d6f > > ambari-server/src/main/java/org/apache/ambari/server/checks/ServiceCheckValidityCheck.java > 2582c71eb95255f0f8081e90473183243f12cdd0 > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java > 59e6622f708e7d8d27c9e28ce2ce58f014a4a5dc > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java > c88b23c8af374dd9bd695b70560079871f3366fd > > ambari-server/src/main/java/org/apache/ambari/server/controller/ConfigurationRequest.java > d26cf16b59897573173ea258133a1c1b4e6f31f1 > > ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java > f2ff181da0327a82adb67e1405ab9ae238b5c4d4 > > ambari-server/src/main/java/org/apache/ambari/server/controller/DeleteIdentityHandler.java > cc84ce24b5e769257ac0e8744a93e3e236bb04e3 > > ambari-server/src/main/java/org/apache/ambari/server/controller/RepositoryResponse.java > 6d0f3fbd4288d31c3e077445e20c3b2bac696930 > > ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceComponentHostRequest.java > ea082c66e128a30368d6be195f3ee270a08e8518 > > ambari-server/src/main/java/org/apache/ambari/server/controller/StackV2.java > 0b0329c31bb5800eb32ba4b437bd57a41a618dbe > > ambari-server/src/main/java/org/apache/ambari/server/controller/StackV2Factory.java > 784b3683ba9d3909bb9e6d900e4175b6a00aec9a > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java > 5104354fce7701fe023723c19d56d25e7adf5219 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BaseClusterRequest.java > a38f478ed05ec88816e6363b31aa102a4a9d353f > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintV2ResourceProvider.java > 6d2c4f06f5c75fbdf9e81c2d711440862f375bb9 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java > cc0cea377233931bf65943f792f6a7e11b074f06 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ExportBlueprintRequest.java > 565369b08b6eeb1a598575e448ce0c6334b6234b > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ProvisionClusterRequest.java > f773fc8aac61f74988dd63a7a8b2cc30053023d2 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RootServiceComponentConfigurationResourceProvider.java > 5a6dff4144bc059ff2614fb1ee4704c0c7a64809 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ScaleClusterRequest.java > 1284c265c150aa03c00b43b364c2163ca4e564a5 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java > 38e1233308a7f423789a1961e3dd8664919f29ae > > ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/RemovableIdentities.java > cd23e834b160f889326f65f68162d5b28906e050 > > ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/UsedIdentities.java > 2f0974e95d7dc27c9b3e33fa426b0e5dc3b3922c > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/StackEntity.java > c479cdd42742ebada75f57efafd764d6b2112148 > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ConfigureAction.java > 6bb248e19bef39ba2edb3671d38ef815d8efb593 > > ambari-server/src/main/java/org/apache/ambari/server/stack/StackManager.java > dc77f19d6389071e45fccb31942c12c8f49e59e0 > > ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java > 4008c21f8ef092e2a1ebd0d7c18ad95bc8206e37 > > ambari-server/src/main/java/org/apache/ambari/server/state/ConfigMergeHelper.java > 36918ccfef596e14a0d3e8e663fb097d065e27a4 > > ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java > a6c650705ad6b90834906bd3ce08149e2528f28e > > ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java > 3b0ebaec5480c74774f9b701ea5e0f39f18f69e5 > > ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java > f4137683aaad84d5a66b93b4559abd7a1fb926bc > > ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintFactory.java > 24b4785562c6c4998103d20aaade7c1754277a76 > > ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintImplV2.java > d31e9d44e7ab79d09b74171387c5ad32caf1a65e > > ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintV2.java > 9ca024810edbed9d9eb3ebaf2107c994db2bf1df > > ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintV2Factory.java > 7b228e57ad176bff43533127b840270efc115fa6 > > ambari-server/src/main/java/org/apache/ambari/server/topology/ClusterConfigurationRequest.java > 3273a4ead6bb3546c16676cd5e748a669e518a45 > > ambari-server/src/main/java/org/apache/ambari/server/topology/ClusterTopology.java > 289f053ccef23d67fa1db9dd298d53d38098ed3b > > ambari-server/src/main/java/org/apache/ambari/server/topology/ClusterTopologyImpl.java > db3f29bda9cc2300ba135dbb7dff7903f219ca41 > > ambari-server/src/main/java/org/apache/ambari/server/topology/ComponentV2.java > 68744d4938f4e9fb171077ef6bee98fc298509fb > > ambari-server/src/main/java/org/apache/ambari/server/topology/Configurable.java > 74308ab3d8caf5745478da2975da5c3c6429a5ba > > ambari-server/src/main/java/org/apache/ambari/server/topology/Configuration.java > 28dbbaa5af9a7321db8773d85be60ad771dd34d6 > > ambari-server/src/main/java/org/apache/ambari/server/topology/ConfigurationFactory.java > 7f9a06f2d2b7f3b51f87304a8e51e019c7f175a8 > > ambari-server/src/main/java/org/apache/ambari/server/topology/Credential.java > 3146e2fecaf9a2e6c2c72aad3fbc69828a49eef4 > > ambari-server/src/main/java/org/apache/ambari/server/topology/HostGroupInfo.java > 7cbdd98cf349b7100bb0ffac96109ff10f959893 > > ambari-server/src/main/java/org/apache/ambari/server/topology/HostGroupV2.java > 8da24bd3c7891a1a988ba0470210f3d4ca908032 > > ambari-server/src/main/java/org/apache/ambari/server/topology/HostGroupV2Impl.java > 01f34da4b530045eb749b8955f1a737701400d19 > > ambari-server/src/main/java/org/apache/ambari/server/topology/PersistedStateImpl.java > 1374a42fa190f89b48913b98908583694c05378b > > ambari-server/src/main/java/org/apache/ambari/server/topology/SecurityConfiguration.java > 7955169da4639d1322d81b4499cc546604889e46 > ambari-server/src/main/java/org/apache/ambari/server/topology/Service.java > 317e29f17cb0b0cfdc86e41f96e6266f75c673f0 > > ambari-server/src/main/java/org/apache/ambari/server/topology/ServiceGroup.java > 7f38b2c67a03165dd5616cf5ea7355e28f44d136 > > ambari-server/src/main/java/org/apache/ambari/server/topology/ServiceId.java > 2d81a07ad37d9f07c7a294316887bf037b6a54d9 > ambari-server/src/main/java/org/apache/ambari/server/topology/Setting.java > 34542e13c4aa66c8e6513d03672a7049accc83b3 > > ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java > 3b7dcc88bacb376afc25c7970e7c1f683f0724b7 > > ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyRequestFactory.java > 751e2d7a8511a0745c09357dd2792ce3bf32ec8d > > ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyRequestFactoryImpl.java > ff79f526ea68af1123daffb054021d8bb5cce51e > > ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyTemplate.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyTemplateFactory.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/topology/tasks/PersistHostResourcesTask.java > 00eb706b348a8b5a7ac5516f7b8a62ece6013b13 > > ambari-server/src/main/java/org/apache/ambari/server/topology/validators/ClusterConfigTypeValidator.java > 7ac75e937d8ac3c8cc6e65d3a5f6d4838fff8bbc > ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql > 84349b6d2fa41fda1ad4e7ddfa0286d4b6814f4c > ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql > f9d5321e76a3152cf47f1a26ce7a4a7265ff3436 > ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql > 227645f1bb9ce09067d98b8048cea29010392692 > ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql > 333a0c3bc3c4885b887c2d4f3a679825434f5422 > ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql > 120bdb60d4b9569ba8f8a7bea844f7537218b212 > ambari-server/src/main/resources/cluster-settings.xml > 70b100aba3d1378a7eb0d29c1c6dc609b42d8d89 > > ambari-server/src/test/java/org/apache/ambari/server/StackAccessExceptionTest.java > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java > f9765f2a8ac1f2f438253ad86401345c6da5e01c > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterResourceProviderTest.java > 6e503a6fd91e691841ba9e9681f8aea8ec448ae4 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ProvisionClusterRequestTest.java > 01d69a51095936e6c10bf3c77447bf0ed65c8131 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ScaleClusterRequestTest.java > b1e52cc120683b0de42b9a4b59514fe37ba076f9 > ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java > dafc5e800a22926058b97abeed53e52cf4e42497 > > ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterImplTest.java > d40679aea7fedf3a858cc7683ea6db7b0e4ff606 > > ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersTest.java > 730d51cb98eef9e0b83c242b12a21ddc2deb8586 > > ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ConcurrentServiceConfigVersionTest.java > 558b334267fd688d46b52a36537e8b893a886197 > > ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ServiceComponentHostConcurrentWriteDeadlockTest.java > ca7a7aceb364a74eb5d2859dc69a838c1c524fdc > > ambari-server/src/test/java/org/apache/ambari/server/topology/AmbariContextTest.java > 16de535efc3c6ba3064ca2be5841b19b69038b1a > > ambari-server/src/test/java/org/apache/ambari/server/topology/BlueprintV2FactoryTest.java > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/topology/BlueprintV2ImplTest.java > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterDeployWithStartOnlyTest.java > a22cef355dd083001a373a823f138a59a28f1c47 > > ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterInstallWithoutStartOnComponentLevelTest.java > ba2118d5a95cd1e1649085640928317ff3bec6b6 > > ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterInstallWithoutStartTest.java > 8d58107618c9b6ba786ea328cd5794e9d300b128 > > ambari-server/src/test/java/org/apache/ambari/server/topology/ConfigurableTest.java > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/topology/ConfigurationFactoryTest.java > 14614fd718b92ea4cdb17080f61a8a5b6daa5267 > > ambari-server/src/test/java/org/apache/ambari/server/topology/SecurityConfigurationTest.java > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/topology/TopologyManagerTest.java > 4eb29b721e8250b1fc91fb4b014abfc90a291762 > > ambari-server/src/test/java/org/apache/ambari/server/topology/TopologyTemplateFactoryTest.java > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/topology/validators/BlueprintImplV2Test.java > ad2cdbdaf60149d12e782674a95cdf8c52ab3e23 > > ambari-server/src/test/java/org/apache/ambari/server/topology/validators/RequiredConfigPropertiesValidatorTest.java > f6b4ec8cb476dc5ef9874328c17599c538163dba > > ambari-server/src/test/java/org/apache/ambari/server/utils/ResourceUtils.java > PRE-CREATION > ambari-server/src/test/resources/blueprintv2/blueprintv2.json > c5e2541ff58697f24f829878e7b3f35226c3ec80 > ambari-server/src/test/resources/blueprintv2/blueprintv2_2.json > PRE-CREATION > ambari-server/src/test/resources/blueprintv2/cluster_template_v2.json > PRE-CREATION > > ambari-server/src/test/resources/blueprintv2/cluster_template_v2_invalid_hostgroup.json > PRE-CREATION > ambari-server/src/test/resources/blueprintv2/security_config.json > PRE-CREATION > > > Diff: https://reviews.apache.org/r/64478/diff/1/ > > > Testing > ------- > > * Tested manually: created cluster via blueprint with two service groups > using HDP 3.0 mpack/stack. > * Added new unit tests, changed some existing ones. > > > Thanks, > > Attila Doroszlai > >
