> On 十二月 4, 2017, 4:24 p.m., Nate Cole wrote: > > ambari-web/app/mappers/alert_definition_summary_mapper.js > > Lines 94-106 (patched) > > <https://reviews.apache.org/r/64204/diff/1/?file=1904495#file1904495line94> > > > > Strange that this isn't getting covered in the above block. I'm not a > > UI engineer, but seems like special casing ZKFC isn't a good idea and that > > any SLAVE-type should be presenting it's alert data?
Yes,We stopped all components and there shows no alerts, Actually, when we opened the tip, there were two critical alerts. Maybe this method is not the best, we can change it. - zhangxiaolu ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64204/#review192706 ----------------------------------------------------------- On 十一月 30, 2017, 11:40 a.m., zhangxiaolu zhangxiaolu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64204/ > ----------------------------------------------------------- > > (Updated 十一月 30, 2017, 11:40 a.m.) > > > Review request for Ambari, Andrii Babiichuk, Alejandro Fernandez, Denys > Buzhor, Dmitro Lisnichenko, Dmytro Sen, Jaimin Jetly, Nate Cole, Richard > Zang, Srimanth Gunturi, Sid Wagle, Vitalyi Brodetskyi, and Yusaku Sako. > > > Bugs: AMBARI-22557 > https://issues.apache.org/jira/browse/AMBARI-22557 > > > Repository: ambari > > > Description > ------- > > (1)zkfc show no alerts when zkfc is down > (2)we should deal with zkfc in front. > > > Diffs > ----- > > ambari-web/app/mappers/alert_definition_summary_mapper.js 29f286e > > > Diff: https://reviews.apache.org/r/64204/diff/1/ > > > Testing > ------- > > done it > > > File Attachments > ---------------- > > AMBARI-22557.patch > > https://reviews.apache.org/media/uploaded/files/2017/11/30/77e10ef5-6f44-4e18-9c8f-20d9fe62d8a9__AMBARI-22557.patch > > > Thanks, > > zhangxiaolu zhangxiaolu > >
