> On Dec. 13, 2017, 3:20 p.m., Nate Cole wrote: > > ambari-server/src/main/python/ambari_server/serverSetup.py > > Lines 870-876 (patched) > > <https://reviews.apache.org/r/64571/diff/1/?file=1915114#file1915114line870> > > > > This appears to always force someone to pick an OS and changes the > > expectation of how the server gets installed. > > > > We shouldn't be changing how things are working today. You should do > > either: > > - After picking JAVA_HOME, then we should ask if they want to customize > > the OS type (as a choice). > > - Use another command line option to add a JAVA_HOME for an OS type. > > No need to ask the type, just use whatever value they put in the option. > > This way, you only have to check for the option to know to write > > "java.home.redhat7". No option means we maintain current behavior. > > > > I would prefer the 2nd option as it's likely easier to document. If we > > start asking "hard choices" the everyday user will get confused.
I have made the changes as per the 2nd option. - Pravin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64571/#review193682 ----------------------------------------------------------- On Dec. 15, 2017, 12:23 p.m., Pravin Dsilva wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64571/ > ----------------------------------------------------------- > > (Updated Dec. 15, 2017, 12:23 p.m.) > > > Review request for Ambari and Nate Cole. > > > Bugs: AMBARI-22404 > https://issues.apache.org/jira/browse/AMBARI-22404 > > > Repository: ambari > > > Description > ------- > > Changes to ambari-server setup script for accepting user values for Java Home > for OS type. > > > Diffs > ----- > > ambari-server/src/main/python/ambari-server.py 655a5d2 > ambari-server/src/main/python/ambari_server/serverSetup.py 13d5348 > ambari-server/src/test/python/TestAmbariServer.py 8ce2457 > > > Diff: https://reviews.apache.org/r/64571/diff/2/ > > > Testing > ------- > > All tests passed > > > Thanks, > > Pravin Dsilva > >
