> On Dec. 15, 2017, 2:01 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java > > Lines 1357-1364 (patched) > > <https://reviews.apache.org/r/64652/diff/1/?file=1918447#file1918447line1357> > > > > These records should just be straight up deleted, not marked this way. > > Myroslav Papirkovskyy wrote: > UI makes explicit call to delete host versions, which will fail if we > just remove records.
If the UI is deleting the records, why do we even need this? - Jonathan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64652/#review193951 ----------------------------------------------------------- On Dec. 15, 2017, noon, Myroslav Papirkovskyy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64652/ > ----------------------------------------------------------- > > (Updated Dec. 15, 2017, noon) > > > Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, and Nate Cole. > > > Bugs: AMBARI-22659 > https://issues.apache.org/jira/browse/AMBARI-22659 > > > Repository: ambari > > > Description > ------- > > Unable go back in install wizard if install was finished at one of hosts. > > ``` > Request > URL:http://ambari:8080/api/v1/stacks/HDP/versions/2.6/repository_versions/1 > > { > "status" : 500, > "message" : "org.apache.ambari.server.controller.spi.SystemException: > Repository version can't be deleted as it is used by the following hosts: > CURRENT on sanjay-divgi-test-2.openstacklocal, > sanjay-divgi-test-5.openstacklocal, sanjay-divgi-test-1.openstacklocal, > sanjay-divgi-test-4.openstacklocal" > } > ``` > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostVersionDAO.java > 158370f3528f796e30a46862e8eb42882001ca02 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostVersionEntity.java > 4a030af122dbe3ceb3c3592c000b126c864dc626 > > ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java > c23b971b85a843433f230b5a94c66ac46c5b1914 > > ambari-server/src/test/java/org/apache/ambari/server/orm/dao/HostVersionDAOTest.java > bb077d6667138acdaeaafa8b07f188b2ce3dc2af > > > Diff: https://reviews.apache.org/r/64652/diff/1/ > > > Testing > ------- > > mvn clean test > manual check > > > Thanks, > > Myroslav Papirkovskyy > >