> On Dec. 18, 2017, noon, Balázs Bence Sári wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java > > Line 625 (original), 629 (patched) > > <https://reviews.apache.org/r/64670/diff/1/?file=1919170#file1919170line629> > > > > Wonder if instead of swallowing an uncaught runtime exception we should > > rather modify the called method (getServiceByConfigType in ClusterImpl) to > > not throw this exception.
Actually the runtime exception is now fixed by [an addendum commit](https://git1-us-west.apache.org/repos/asf?p=ambari.git;a=commit;h=bfeaa1071e). I'll remove the catch. > On Dec. 18, 2017, noon, Balázs Bence Sári wrote: > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/StackEntity.java > > Line 64 (original), 64 (patched) > > <https://reviews.apache.org/r/64670/diff/1/?file=1919175#file1919175line64> > > > > This column will shortly be removed in another patch so I'd prefer not > > changing it. Sure. - Attila ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64670/#review194055 ----------------------------------------------------------- On Dec. 17, 2017, 2:35 p.m., Attila Doroszlai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64670/ > ----------------------------------------------------------- > > (Updated Dec. 17, 2017, 2:35 p.m.) > > > Review request for Ambari, Balázs Bence Sári, Dmytro Sen, Jayush Luniya, > Madhuvanthi Radhakrishnan, Robert Nettleton, Swapan Shridhar, and Vitalyi > Brodetskyi. > > > Bugs: AMBARI-22660 > https://issues.apache.org/jira/browse/AMBARI-22660 > > > Repository: ambari > > > Description > ------- > > Fixed mostly `ServiceGroupNotFound` due to `serviceGroupName=` and `Guice > provision errors` due to `serviceGroup=null` in `ServiceFactory.createNew()`. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java > 25cfaf84c56b9b84f806ce43b9f8cd3fa4d36265 > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java > 1bf5299e3c687403cbb8ba72b670929de5f53a12 > > ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceComponentHostRequest.java > 2554c2544875f70bb10432dc4bd5685f0b3c9643 > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ServiceGroupDAO.java > 97659f74b5df2d837068644bce8dbd3e5319da1c > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostComponentStateEntity.java > 8994384956db0bac467cb61fd13afba07bbd21ab > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceGroupEntity.java > fedaee86fbbf4286b76a1c4758651f535bb6f642 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/StackEntity.java > c479cdd42742ebada75f57efafd764d6b2112148 > > ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java > bdda9a79ec952fda4ee64c46c6e2ed1c7c9e2d58 > > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java > aff6d74f483ec365e3c8a96124f66e808c5b95ff > > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java > 14ab8cf7baa26771f3b9eb72cf62518f9e93a7ce > > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java > 0cc64e9d66b9afb21c62ab5b6346166d58e42036 > > ambari-server/src/test/java/org/apache/ambari/server/controller/BackgroundCustomCommandExecutionTest.java > 0b07fb7f1b31dde693116a97edc3a5425a82ba37 > > ambari-server/src/test/java/org/apache/ambari/server/controller/RefreshYarnCapacitySchedulerReleaseConfigTest.java > 990000a7de370572ba055c31a056ea9012a66522 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AbstractResourceProviderTest.java > 0f04e744bad5f4005428dc018c9850aecdccc3d5 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ComponentResourceProviderTest.java > be7134e7c51426e941b92b3ac8aaa9f9935c0095 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostComponentResourceProviderTest.java > bad63b789463653df5eaaabf89a2b0b917cebdbf > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/JMXHostProviderTest.java > d8575e7d6dfa9bda5671027bdf3ff152749a9ee9 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ServiceGroupResourceProviderTest.java > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ServiceResourceProviderTest.java > 3a239689f2f5b21528f9b47f0b3f26963dc2a2c6 > > ambari-server/src/test/java/org/apache/ambari/server/controller/logging/LoggingSearchPropertyProviderTest.java > e9f7c4df07b623ac4c50e6869f80715b183fd45c > ambari-server/src/test/java/org/apache/ambari/server/events/EventsTest.java > 2376079af4f45d17eec0cc1e91bcf0ec6ab96b90 > > ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListenerTest.java > 970b7cc6095f5607551fe66a5ea3792977582325 > ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java > 1a8340ab0aec52b6231177f34ecec32240ed7cbb > > ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertDispatchDAOTest.java > b5525658c2b45a2ef3ba649e66ff95b673990519 > > ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ComponentVersionCheckActionTest.java > 3ceb6fa1d6bbb217b70cbc64e8687d74f08cf85e > > ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ConfigureActionTest.java > cc2bba7f4c6bdf930c0edac19810caf645759675 > > ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/CreateAndConfigureActionTest.java > 1bad2199d07017721d021c646cf8c87d604f48ea > > ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java > e9da5641a8ad0e44f9b04c2cf035635bafa7d535 > > ambari-server/src/test/java/org/apache/ambari/server/state/ServiceComponentTest.java > f4c3d20b435e048a60d64a874db210fa9a033bc6 > > ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AlertEventPublisherTest.java > 50555d09ac58572627cec7d98ffa2a452e74cbc0 > > ambari-server/src/test/java/org/apache/ambari/server/state/alerts/InitialAlertEventTest.java > 37e08785db252910d3eafb346c97fc99cb12cff9 > > ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterDeadlockTest.java > 88275bde3764f72b7a86205087e4c1d60f0fc539 > > ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java > bbfc838d6aeb0ce26e60bd8f2ea9a7d644c2ae5b > > ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersDeadlockTest.java > 42141f1d3aaf631e414f11d61043c88ef8a5e6c1 > > ambari-server/src/test/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostTest.java > 8568b8c77e115913257949dee97074a3d2757499 > > ambari-server/src/test/java/org/apache/ambari/server/testing/DBInconsistencyTests.java > 3b636052efdd0f8e742a8135940b9d30146e7432 > > > Diff: https://reviews.apache.org/r/64670/diff/1/ > > > Testing > ------- > > Unit tests before: > > ``` > Tests run: 4946, Failures: 212, Errors: 443, Skipped: 35 > ``` > > After: > > ``` > Tests run: 4950, Failures: 191, Errors: 263, Skipped: 37 > ``` > > Individual test classes affected: > > ``` > -Tests run: 6, Failures: 0, Errors: 1, Skipped: 0 - in > org.apache.ambari.server.agent.TestHeartbeatMonitor > +Tests run: 6, Failures: 0, Errors: 0, Skipped: 0 - in > org.apache.ambari.server.agent.TestHeartbeatMonitor > -Tests run: 122, Failures: 3, Errors: 65, Skipped: 4 - in > org.apache.ambari.server.controller.AmbariManagementControllerTest > +Tests run: 122, Failures: 1, Errors: 0, Skipped: 6 - in > org.apache.ambari.server.controller.AmbariManagementControllerTest > -Tests run: 1, Failures: 1, Errors: 0, Skipped: 0 - in > org.apache.ambari.server.controller.BackgroundCustomCommandExecutionTest > +Tests run: 1, Failures: 0, Errors: 0, Skipped: 0 - in > org.apache.ambari.server.controller.BackgroundCustomCommandExecutionTest > -Tests run: 23, Failures: 3, Errors: 8, Skipped: 0 - in > org.apache.ambari.server.controller.internal.ComponentResourceProviderTest > +Tests run: 23, Failures: 0, Errors: 0, Skipped: 0 - in > org.apache.ambari.server.controller.internal.ComponentResourceProviderTest > -Tests run: 14, Failures: 3, Errors: 3, Skipped: 0 - in > org.apache.ambari.server.controller.internal.HostComponentResourceProviderTest > +Tests run: 14, Failures: 0, Errors: 0, Skipped: 0 - in > org.apache.ambari.server.controller.internal.HostComponentResourceProviderTest > -Tests run: 11, Failures: 0, Errors: 2, Skipped: 0 - in > org.apache.ambari.server.controller.internal.JMXHostProviderTest > +Tests run: 11, Failures: 0, Errors: 0, Skipped: 0 - in > org.apache.ambari.server.controller.internal.JMXHostProviderTest > -Tests run: 26, Failures: 5, Errors: 5, Skipped: 0 - in > org.apache.ambari.server.controller.internal.ServiceResourceProviderTest > +Tests run: 26, Failures: 5, Errors: 2, Skipped: 0 - in > org.apache.ambari.server.controller.internal.ServiceResourceProviderTest > -Tests run: 25, Failures: 0, Errors: 23, Skipped: 0 - in > org.apache.ambari.server.controller.internal.UpgradeResourceProviderTest > +Tests run: 25, Failures: 0, Errors: 4, Skipped: 0 - in > org.apache.ambari.server.controller.internal.UpgradeResourceProviderTest > -Tests run: 18, Failures: 12, Errors: 0, Skipped: 0 - in > org.apache.ambari.server.controller.logging.LoggingSearchPropertyProviderTest > +Tests run: 18, Failures: 0, Errors: 0, Skipped: 0 - in > org.apache.ambari.server.controller.logging.LoggingSearchPropertyProviderTest > -Tests run: 1, Failures: 0, Errors: 1, Skipped: 0 - in > org.apache.ambari.server.controller.metrics.RestMetricsPropertyProviderTest > +Tests run: 5, Failures: 0, Errors: 0, Skipped: 0 - in > org.apache.ambari.server.controller.metrics.RestMetricsPropertyProviderTest > -Tests run: 8, Failures: 0, Errors: 8, Skipped: 0 - in > org.apache.ambari.server.events.EventsTest > +Tests run: 8, Failures: 0, Errors: 0, Skipped: 0 - in > org.apache.ambari.server.events.EventsTest > -Tests run: 6, Failures: 0, Errors: 6, Skipped: 0 - in > org.apache.ambari.server.events.listeners.upgrade.HostVersionOutOfSyncListenerTest > +Tests run: 6, Failures: 1, Errors: 0, Skipped: 0 - in > org.apache.ambari.server.events.listeners.upgrade.HostVersionOutOfSyncListenerTest > -Tests run: 3, Failures: 0, Errors: 3, Skipped: 0 - in > org.apache.ambari.server.serveraction.upgrades.ComponentVersionCheckActionTest > +Tests run: 3, Failures: 0, Errors: 0, Skipped: 0 - in > org.apache.ambari.server.serveraction.upgrades.ComponentVersionCheckActionTest > -Tests run: 1, Failures: 0, Errors: 1, Skipped: 0 - in > org.apache.ambari.server.serveraction.upgrades.CreateAndConfigureActionTest > +Tests run: 1, Failures: 0, Errors: 0, Skipped: 0 - in > org.apache.ambari.server.serveraction.upgrades.CreateAndConfigureActionTest > -Tests run: 5, Failures: 0, Errors: 2, Skipped: 0 - in > org.apache.ambari.server.serveraction.upgrades.UpgradeActionTest > +Tests run: 5, Failures: 0, Errors: 0, Skipped: 0 - in > org.apache.ambari.server.serveraction.upgrades.UpgradeActionTest > -Tests run: 25, Failures: 0, Errors: 3, Skipped: 0 - in > org.apache.ambari.server.stack.StackManagerTest > +Tests run: 25, Failures: 0, Errors: 0, Skipped: 0 - in > org.apache.ambari.server.stack.StackManagerTest > -Tests run: 10, Failures: 0, Errors: 10, Skipped: 0 - in > org.apache.ambari.server.state.ServiceComponentTest > +Tests run: 10, Failures: 0, Errors: 0, Skipped: 0 - in > org.apache.ambari.server.state.ServiceComponentTest > -Tests run: 6, Failures: 0, Errors: 6, Skipped: 0 - in > org.apache.ambari.server.state.alerts.AlertEventPublisherTest > +Tests run: 6, Failures: 0, Errors: 0, Skipped: 0 - in > org.apache.ambari.server.state.alerts.AlertEventPublisherTest > -Tests run: 17, Failures: 0, Errors: 17, Skipped: 0 - in > org.apache.ambari.server.state.alerts.AlertReceivedListenerTest > +Tests run: 17, Failures: 0, Errors: 0, Skipped: 0 - in > org.apache.ambari.server.state.alerts.AlertReceivedListenerTest > -Tests run: 1, Failures: 0, Errors: 1, Skipped: 0 - in > org.apache.ambari.server.state.alerts.InitialAlertEventTest > +Tests run: 1, Failures: 0, Errors: 0, Skipped: 0 - in > org.apache.ambari.server.state.alerts.InitialAlertEventTest > -Tests run: 3, Failures: 0, Errors: 3, Skipped: 0 - in > org.apache.ambari.server.state.cluster.AlertDataManagerTest > +Tests run: 3, Failures: 0, Errors: 0, Skipped: 0 - in > org.apache.ambari.server.state.cluster.AlertDataManagerTest > -Tests run: 4, Failures: 0, Errors: 4, Skipped: 0 - in > org.apache.ambari.server.state.cluster.ClusterDeadlockTest > +Tests run: 4, Failures: 0, Errors: 0, Skipped: 0 - in > org.apache.ambari.server.state.cluster.ClusterDeadlockTest > -Tests run: 35, Failures: 3, Errors: 15, Skipped: 0 - in > org.apache.ambari.server.state.cluster.ClusterTest > +Tests run: 35, Failures: 2, Errors: 7, Skipped: 0 - in > org.apache.ambari.server.state.cluster.ClusterTest > -Tests run: 3, Failures: 0, Errors: 3, Skipped: 0 - in > org.apache.ambari.server.state.cluster.ClustersDeadlockTest > +Tests run: 3, Failures: 0, Errors: 0, Skipped: 0 - in > org.apache.ambari.server.state.cluster.ClustersDeadlockTest > -Tests run: 9, Failures: 0, Errors: 3, Skipped: 0 - in > org.apache.ambari.server.state.cluster.ClustersTest > +Tests run: 9, Failures: 0, Errors: 2, Skipped: 0 - in > org.apache.ambari.server.state.cluster.ClustersTest > -Tests run: 1, Failures: 0, Errors: 1, Skipped: 0 - in > org.apache.ambari.server.state.services.RetryUpgradeActionServiceTest > +Tests run: 1, Failures: 0, Errors: 0, Skipped: 0 - in > org.apache.ambari.server.state.services.RetryUpgradeActionServiceTest > -Tests run: 13, Failures: 1, Errors: 2, Skipped: 2 - in > org.apache.ambari.server.state.svccomphost.ServiceComponentHostTest > +Tests run: 13, Failures: 1, Errors: 1, Skipped: 2 - in > org.apache.ambari.server.state.svccomphost.ServiceComponentHostTest > ``` > > > Thanks, > > Attila Doroszlai > >
