----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64693/#review194150 -----------------------------------------------------------
Unit tests? - Jayush Luniya On Dec. 18, 2017, 11:53 p.m., Vitalyi Brodetskyi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64693/ > ----------------------------------------------------------- > > (Updated Dec. 18, 2017, 11:53 p.m.) > > > Review request for Ambari, Jayush Luniya, Madhuvanthi Radhakrishnan, and > Swapan Shridhar. > > > Bugs: AMBARI-22249 > https://issues.apache.org/jira/browse/AMBARI-22249 > > > Repository: ambari > > > Description > ------- > > Chnaged adding service group dependency by name, not by id. Fixed > add/get/delete requests. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceGroupKey.java > 9389f0c > > ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceGroupDependencyRequest.java > 9f4eea3 > > ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceGroupDependencyResponse.java > 1a4b4ed > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceGroupDependencyResourceProvider.java > aac7102 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceGroupDependencyEntity.java > ee0beeb > > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceGroupImpl.java > 914b65a > > > Diff: https://reviews.apache.org/r/64693/diff/1/ > > > Testing > ------- > > > Thanks, > > Vitalyi Brodetskyi > >
