----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64747/#review194234 -----------------------------------------------------------
ambari-agent/src/main/python/ambari_agent/ActionQueue.py Line 214 (original), 215 (patched) <https://reviews.apache.org/r/64747/#comment272963> Not a issue. Just wondering if that does make a change in calls number or just a refactoring. - Andrew Onischuk On Dec. 20, 2017, 12:18 p.m., Attila Magyar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64747/ > ----------------------------------------------------------- > > (Updated Dec. 20, 2017, 12:18 p.m.) > > > Review request for Ambari, Attila Doroszlai, Andrew Onischuk, and Eugene > Chekanskiy. > > > Bugs: AMBARI-22677 > https://issues.apache.org/jira/browse/AMBARI-22677 > > > Repository: ambari > > > Description > ------- > > The pprint.pformat is relatively slow and ambari agent calls it frequently > just to generate debug log. > > > Diffs > ----- > > ambari-agent/src/main/python/ambari_agent/ActionQueue.py f1b3a42 > ambari-agent/src/main/python/ambari_agent/CommandStatusDict.py 7a97f3f > ambari-agent/src/main/python/ambari_agent/Controller.py bc923c3 > ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py > 645f824 > ambari-agent/src/main/python/ambari_agent/DataCleaner.py 0b66fa7 > ambari-agent/src/main/python/ambari_agent/Heartbeat.py d7c0325 > ambari-agent/src/main/python/ambari_agent/LiveStatus.py b6d54ed > ambari-agent/src/main/python/ambari_agent/PythonExecutor.py ea6f895 > ambari-agent/src/main/python/ambari_agent/PythonReflectiveExecutor.py > b27d7d1 > ambari-agent/src/main/python/ambari_agent/RecoveryManager.py be335f2 > ambari-agent/src/main/python/ambari_agent/StatusCommandsExecutor.py f42e134 > ambari-agent/src/main/python/ambari_agent/alerts/ams_alert.py 70f100f > ambari-agent/src/main/python/ambari_agent/alerts/metric_alert.py 803bdc6 > ambari-agent/src/main/python/ambari_agent/security.py 45de7bb > > > Diff: https://reviews.apache.org/r/64747/diff/1/ > > > Testing > ------- > > ran unittests, created a cluster successfully with ambari > > > Thanks, > > Attila Magyar > >