----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64552/#review194316 -----------------------------------------------------------
Ship it! Ship It! - Andrew Onischuk On Dec. 12, 2017, 7:36 p.m., Akira Ajisaka wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64552/ > ----------------------------------------------------------- > > (Updated Dec. 12, 2017, 7:36 p.m.) > > > Review request for Ambari, Andrew Onischuk and Dmytro Sen. > > > Bugs: AMBARI-22637 > https://issues.apache.org/jira/browse/AMBARI-22637 > > > Repository: ambari > > > Description > ------- > > os.path.dirname(path) does not return parent directory if the path ends with > '/'. > We should use os.path.dirname(os.path.abspath(path)) to get parent directory. > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn.py > d077c848f2 > > ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/package/scripts/yarn.py > 7731aeb09b > > contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/YARN/package/scripts/yarn.py > 147fb38dc2 > > > Diff: https://reviews.apache.org/r/64552/diff/1/ > > > Testing > ------- > > Jenkins result > > -1 overall. Here are the results of testing the latest attachment > http://issues.apache.org/jira/secure/attachment/12901718/AMBARI-22637.001.patch > against trunk revision . > > +1 @author. The patch does not contain any @author tags. > > -1 tests included. The patch doesn't appear to include any new or modified > tests. > Please justify why no new tests are needed for this patch. > Also please list what manual steps were performed to verify this patch. > > +1 release audit. The applied patch does not increase the total number of > release audit warnings. > > +1 javac. The applied patch does not increase the total number of javac > compiler warnings. > > +1 core tests. The patch passed unit tests in ambari-server. > > Console output: > https://builds.apache.org/job/Ambari-trunk-test-patch/12831//console > > > Thanks, > > Akira Ajisaka > >
