----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64772/#review194345 -----------------------------------------------------------
Fix it, then Ship it! Nice. contrib/management-packs/isilon-onefs-mpack/pom.xml Lines 33 (patched) <https://reviews.apache.org/r/64772/#comment273107> Looks like this doesn't work (due to different depth of project directory) and custom python path logic is required in `unitTests.py`. Can you please remove (also `pathsep`, and also their usage below) to avoid confusion? contrib/management-packs/isilon-onefs-mpack/pom.xml Lines 106 (patched) <https://reviews.apache.org/r/64772/#comment273108> This argument is actually ignored by `unitTests.py`. - Attila Doroszlai On Dec. 21, 2017, 3:46 p.m., Attila Magyar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64772/ > ----------------------------------------------------------- > > (Updated Dec. 21, 2017, 3:46 p.m.) > > > Review request for Ambari, Attila Doroszlai, Jonathan Hurley, and Nate Cole. > > > Bugs: AMBARI-22674 > https://issues.apache.org/jira/browse/AMBARI-22674 > > > Repository: ambari > > > Description > ------- > > A service advisor was added to the mpack to keep the hostnames of > core-site/fs.defaultFS, hdfs-site/dfs.namenode.http-address and > hdfs-site/dfs.namenode.https-address in sync. > > The user needs to enter the onefs/onefs_host and the service advisor will > update the other properties accordingly. > > > Diffs > ----- > > ambari-agent/src/main/python/ambari_agent/alerts/ams_alert.py 70f100f > ambari-agent/src/main/python/ambari_agent/alerts/base_alert.py 5c0305e > ambari-agent/src/main/python/ambari_agent/alerts/metric_alert.py 803bdc6 > ambari-agent/src/main/python/ambari_agent/alerts/port_alert.py 02cc91c > ambari-agent/src/main/python/ambari_agent/alerts/web_alert.py 0e400f7 > ambari-common/src/main/python/ambari_commons/inet_utils.py 5fd3e88 > contrib/management-packs/isilon-onefs-mpack/pom.xml 5d8f215 > > contrib/management-packs/isilon-onefs-mpack/src/main/resources/addon-services/ONEFS/1.0.0/configuration/core-site.xml > 7d3acd7 > > contrib/management-packs/isilon-onefs-mpack/src/main/resources/addon-services/ONEFS/1.0.0/configuration/hdfs-site.xml > cb6544f > > contrib/management-packs/isilon-onefs-mpack/src/main/resources/addon-services/ONEFS/1.0.0/configuration/onefs.xml > PRE-CREATION > > contrib/management-packs/isilon-onefs-mpack/src/main/resources/addon-services/ONEFS/1.0.0/metainfo.xml > 5ba562e > > contrib/management-packs/isilon-onefs-mpack/src/main/resources/addon-services/ONEFS/1.0.0/package/scripts/params_linux.py > 953efdc > > contrib/management-packs/isilon-onefs-mpack/src/main/resources/addon-services/ONEFS/1.0.0/service_advisor.py > PRE-CREATION > > contrib/management-packs/isilon-onefs-mpack/src/main/resources/addon-services/ONEFS/1.0.0/themes/theme.json > PRE-CREATION > > contrib/management-packs/isilon-onefs-mpack/src/test/python/TestServiceAdvisor.py > PRE-CREATION > contrib/management-packs/isilon-onefs-mpack/src/test/python/unitTests.py > PRE-CREATION > > > Diff: https://reviews.apache.org/r/64772/diff/1/ > > > Testing > ------- > > - cluster creation, changed configs manually > > existing tests: passed > > > Thanks, > > Attila Magyar > >
