----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64781/#review194347 -----------------------------------------------------------
Ship it! Ship It! - Tim Thorpe On Dec. 21, 2017, 4:29 p.m., Di Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64781/ > ----------------------------------------------------------- > > (Updated Dec. 21, 2017, 4:29 p.m.) > > > Review request for Ambari and Tim Thorpe. > > > Bugs: AMBARI-22680 > https://issues.apache.org/jira/browse/AMBARI-22680 > > > Repository: ambari > > > Description > ------- > > This is because the Ambari server backend never validated anything. It just > simply sent back HTTP 200 as a dummy response. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryResourceProvider.java > edec1ee > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryResourceProviderTest.java > abdef9b > > > Diff: https://reviews.apache.org/r/64781/diff/1/ > > > Testing > ------- > > unit test, patch a trunk cluster with change, provide an invalid url during > cluster install, verify the UI stops users from proceeding to the next page > with an error about the URL being invalid. verify the UI moves to the next > page when the urls are correct. > > > Thanks, > > Di Li > >
