-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64607/#review194364
-----------------------------------------------------------


Ship it!




Ship It!

- Sid Wagle


On Dec. 15, 2017, 8:57 a.m., Krisztian Kasa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64607/
> -----------------------------------------------------------
> 
> (Updated Dec. 15, 2017, 8:57 a.m.)
> 
> 
> Review request for Ambari, Miklos Gergely, Oliver Szabo, and Sid Wagle.
> 
> 
> Bugs: AMBARI-22514 and AMBARI-22653
>     https://issues.apache.org/jira/browse/AMBARI-22514
>     https://issues.apache.org/jira/browse/AMBARI-22653
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> * Integration test environment for ambari-infra-manager using docker-compose 
> and jbehave
> * test cases for testing data export jobs
> 
> * deleting temporary files as soon as the file becomes unnecessary
> * configuring solr data export like jobs in property files only, no hardcoded 
> job and step configurations: query can be defined in property file for 
> pulling data from solr
> * validate job property values at application startup and before job execution
> * s3 upload support
> * not just interval end but interval start can be specified when exporting
> * interval start and end values can be other type than dateTime
> 
> 
> Diffs
> -----
> 
>   ambari-infra/ambari-infra-manager-it/pom.xml PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager-it/src/test/java/org/apache/ambari/infra/InfraClient.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager-it/src/test/java/org/apache/ambari/infra/InfraManagerStories.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager-it/src/test/java/org/apache/ambari/infra/OffsetDateTimeConverter.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager-it/src/test/java/org/apache/ambari/infra/steps/AbstractInfraSteps.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager-it/src/test/java/org/apache/ambari/infra/steps/ExportJobsSteps.java
>  PRE-CREATION 
>   ambari-infra/ambari-infra-manager-it/src/test/resources/log4j.properties 
> PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager-it/src/test/resources/stories/infra_api_tests.story
>  PRE-CREATION 
>   ambari-infra/ambari-infra-manager/docker/Dockerfile adb584acec 
>   ambari-infra/ambari-infra-manager/docker/docker-compose.yml PRE-CREATION 
>   ambari-infra/ambari-infra-manager/docker/infra-manager-docker-compose.sh 
> PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/ObjectSource.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/AbstractFileAction.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/CompositeFileAction.java
>  84ce16074b 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/Document.java
>  84f5ece26f 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/DocumentExportConfiguration.java
>  69f41d333e 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/DocumentExportJobListener.java
>  f1df46cfcc 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/DocumentExportProperties.java
>  d6301c0c0e 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/DocumentExportPropertyMap.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/DocumentExportStepListener.java
>  3bab6d505e 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/DocumentItemReader.java
>  a4378a4340 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/DocumentIterator.java
>  6232cfc4c6 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/DocumentSource.java
>  c9871a3660 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/FileAction.java
>  26a8c6310f 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/LocalDocumentItemWriter.java
>  02d898d979 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/S3Properties.java
>  495401d633 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/S3Uploader.java
>  3214e50e91 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/SolrDocumentIterator.java
>  db4069bad7 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/SolrDocumentSource.java
>  2181ba368d 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/SolrQueryBuilder.java
>  d0f6d40155 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/SolrQueryProperties.java
>  444a15b267 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/TarGzCompressor.java
>  8e34ca9b47 
>   
> ambari-infra/ambari-infra-manager/src/main/resources/infra-manager.properties 
> 7ef70aaf51 
>   
> ambari-infra/ambari-infra-manager/src/test/java/org/apache/ambari/infra/job/archive/DocumentExportPropertiesTest.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager/src/test/java/org/apache/ambari/infra/job/archive/DocumentItemReaderTest.java
>  942713f253 
>   
> ambari-infra/ambari-infra-manager/src/test/java/org/apache/ambari/infra/job/archive/LocalDocumentItemWriterTest.java
>  6411ff1788 
>   
> ambari-infra/ambari-infra-manager/src/test/java/org/apache/ambari/infra/job/archive/SolrQueryBuilderTest.java
>  4d5ebf1144 
>   
> ambari-infra/ambari-infra-manager/src/test/java/org/apache/ambari/infra/job/archive/SolrQueryPropertiesTest.java
>  PRE-CREATION 
>   ambari-infra/pom.xml e4b6a7601f 
> 
> 
> Diff: https://reviews.apache.org/r/64607/diff/2/
> 
> 
> Testing
> -------
> 
> * unit tests,
> * integration tests using docker containers
> * manual testing using docker containers and ide
> 
> 
> Thanks,
> 
> Krisztian Kasa
> 
>

Reply via email to