----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64775/#review194436 -----------------------------------------------------------
ambari-server/src/main/python/bootstrap.py Lines 762-763 (patched) <https://reviews.apache.org/r/64775/#comment273203> Use "".format() syntax here. Should we give more information here? How will we tell the user what to do? How do they get the os_type into ambari.properties? - Nate Cole On Dec. 21, 2017, 10:25 a.m., Sneha Kanekar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64775/ > ----------------------------------------------------------- > > (Updated Dec. 21, 2017, 10:25 a.m.) > > > Review request for Ambari and Nate Cole. > > > Bugs: AMBARI-22394 > https://issues.apache.org/jira/browse/AMBARI-22394 > > > Repository: ambari > > > Description > ------- > > Ambari configuration will have list of repo urls for each os type. During > bootstrap, the stored repo url will be used to correct the base url from > ambari repo file on agent host. > > > Diffs > ----- > > ambari-server/src/main/python/bootstrap.py f1c53ce > ambari-server/src/main/python/os_check_type.py da37560 > ambari-server/src/main/python/setupAgent.py efc3d7c > ambari-server/src/test/python/TestBootstrap.py bea47f4 > ambari-server/src/test/python/TestSetupAgent.py 0b33e9f > > > Diff: https://reviews.apache.org/r/64775/diff/1/ > > > Testing > ------- > > Tests were successful in ambari-server. > > > Thanks, > > Sneha Kanekar > >
