----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64948/#review194760 -----------------------------------------------------------
Ship it! Ship It! - Nate Cole On Jan. 4, 2018, 9:06 a.m., Attila Magyar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64948/ > ----------------------------------------------------------- > > (Updated Jan. 4, 2018, 9:06 a.m.) > > > Review request for Ambari, Aleksandr Kovalenko, Nate Cole, Oleg Nechiporenko, > and Robert Levas. > > > Bugs: AMBARI-22449 > https://issues.apache.org/jira/browse/AMBARI-22449 > > > Repository: ambari > > > Description > ------- > > Ambari checks if a component needs certain client components before adding a > component. The dependency check should take compatible services (like > ONEFS_CLIENT - HDFS_CLIENT) into consideration. The componentType is used to > indicate HDFS compatiblity. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceComponentResponse.java > 75fac6e > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceComponentResourceProvider.java > a221248 > > ambari-server/src/main/java/org/apache/ambari/server/state/ComponentInfo.java > d361a29 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/metainfo.xml > 6bbb583 > > ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/metainfo.xml > 0c629f3 > ambari-web/app/controllers/main/host/details.js e3b5471 > ambari-web/app/controllers/wizard/step8_controller.js e64a09a > ambari-web/app/mappers/stack_service_mapper.js 368a182 > ambari-web/app/models/stack_service_component.js 27aa8aa > ambari-web/test/controllers/main/host/details_test.js f9df36d > ambari-web/test/controllers/wizard/step8_test.js 2a52598 > > > Diff: https://reviews.apache.org/r/64948/diff/1/ > > > Testing > ------- > > 1. installed HBASE + ONEFS > 2. checked if ONEFS_CLIENT was installed automatically on the host wher > HBASE_MASTER was located > > 1. tried to add an HBASE_MASTER afterwards to a host where no ONEFS_CLIENT > was installed > 2. ambari has shown a message about the missing client component > 3. added a ONEFS_CLIENT to the host manually and retried adding HBASE_MASTER > 4. HBASE_MASTER was successfully installed > > existing tests: passed > > > Thanks, > > Attila Magyar > >