----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64984/#review194888 -----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatProcessor.java Lines 480 (patched) <https://reviews.apache.org/r/64984/#comment273966> Why is this needed to be done on HB processing? Can you please remind me if we still piggy back tags on HB, in any case shouldn't tags matching determine staleness? - Sid Wagle On Jan. 5, 2018, 6:59 p.m., Myroslav Papirkovskyy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64984/ > ----------------------------------------------------------- > > (Updated Jan. 5, 2018, 6:59 p.m.) > > > Review request for Ambari, Andrew Onischuk, Dmytro Grinenko, Eugene > Chekanskiy, and Sid Wagle. > > > Bugs: AMBARI-22737 > https://issues.apache.org/jira/browse/AMBARI-22737 > > > Repository: ambari > > > Description > ------- > > /events/hostcomponents topic should react on maintenance state on/off and > stale configs events. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatProcessor.java > fa697278c34d40afc12b93090a4663543bd94923 > > ambari-server/src/main/java/org/apache/ambari/server/events/AmbariEvent.java > 5f410f563c8bc1c167f72dd640b7c84a639a7040 > > ambari-server/src/main/java/org/apache/ambari/server/events/HostComponentUpdate.java > e48014654c127341f25f5f79ec67b93d973c3d5b > > ambari-server/src/main/java/org/apache/ambari/server/events/StaleConfigsUpdateEvent.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/events/listeners/hostcomponents/HostComponentsUpdateListener.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/events/listeners/hosts/HostUpdateListener.java > 6cb831f153e5748d19be26d4f899522fe9420ed6 > ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java > 7cc5799251913dd29ffb83ce13bf7ec328cab3a5 > > ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java > b5ade0c841009235c8a2cee593ca8f992902e4ec > > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java > 7f1c746eda955edcc3503595789d2bdc0b50891d > > ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java > d3ba1d50f8d7356d1445637fdc27d00b715de20e > > ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java > ef7d471affd191400e5ccc259420ae4c544789f8 > > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java > a1f28f1b3a5dfc5e30b5a2348b681cca892746ba > > ambari-server/src/test/java/org/apache/ambari/server/controller/RefreshYarnCapacitySchedulerReleaseConfigTest.java > ef186f1ac02fa88f035821e073fdcdd6c0a3cada > > ambari-server/src/test/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostTest.java > 48864cc3baab7f7b0887f7dd68a5bbdcd9925698 > > > Diff: https://reviews.apache.org/r/64984/diff/1/ > > > Testing > ------- > > manual testing > > > Thanks, > > Myroslav Papirkovskyy > >
