----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64990/#review194903 -----------------------------------------------------------
Fix it, then Ship it! ambari-server/src/main/java/org/apache/ambari/server/events/UpgradeUpdateEvent.java Lines 38 (patched) <https://reviews.apache.org/r/64990/#comment273985> Can you add some javadoc please sa to what this event represents. - Sid Wagle On Jan. 5, 2018, 8:13 p.m., Myroslav Papirkovskyy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64990/ > ----------------------------------------------------------- > > (Updated Jan. 5, 2018, 8:13 p.m.) > > > Review request for Ambari, Andrew Onischuk, Dmytro Grinenko, Eugene > Chekanskiy, and Sid Wagle. > > > Bugs: AMBARI-22742 > https://issues.apache.org/jira/browse/AMBARI-22742 > > > Repository: ambari > > > Description > ------- > > Server should raise events to publish created/updated upgrades to STOMP topic. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java > 1fbf1304135eabd11d7595060d660c38031afbb1 > > ambari-server/src/main/java/org/apache/ambari/server/events/AmbariUpdateEvent.java > cfd910b94bb10fd0ab961dd809313ef525c2b57e > > ambari-server/src/main/java/org/apache/ambari/server/events/DefaultMessageEmitter.java > 3ae5955d497955dba141d0af77701bdba5573fea > > ambari-server/src/main/java/org/apache/ambari/server/events/RequestUpdateEvent.java > 4133c6292b85bd37ca033b24e56c987da83862a0 > > ambari-server/src/main/java/org/apache/ambari/server/events/UpgradeUpdateEvent.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/UpgradeUpdateListener.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/64990/diff/1/ > > > Testing > ------- > > manual testing > > > Thanks, > > Myroslav Papirkovskyy > >
