----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64985/#review194906 -----------------------------------------------------------
Ship it! Are we using serviceType because for 3.0, we will have configurations per serviceType and not per serviceInstance? - Madhuvanthi Radhakrishnan On Jan. 5, 2018, 7:10 p.m., Attila Doroszlai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64985/ > ----------------------------------------------------------- > > (Updated Jan. 5, 2018, 7:10 p.m.) > > > Review request for Ambari, Balázs Bence Sári, Jayush Luniya, Madhuvanthi > Radhakrishnan, and Robert Nettleton. > > > Bugs: AMBARI-22244 > https://issues.apache.org/jira/browse/AMBARI-22244 > > > Repository: ambari > > > Description > ------- > > cherry-picked from `branch-feature-AMBARI-14714-blueprintv2` branch: > > Replaced `serviceName` with `serviceType` in more places > (`getDefaultProperties`, `getServiceProperties` and `getReadOnlyProperties` > calls). > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/checks/ServiceCheckValidityCheck.java > 2582c71eb95255f0f8081e90473183243f12cdd0 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java > 38e1233308a7f423789a1961e3dd8664919f29ae > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ConfigureAction.java > 6bb248e19bef39ba2edb3671d38ef815d8efb593 > > ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java > 4008c21f8ef092e2a1ebd0d7c18ad95bc8206e37 > > ambari-server/src/main/java/org/apache/ambari/server/state/ConfigMergeHelper.java > 36918ccfef596e14a0d3e8e663fb097d065e27a4 > > ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java > a6c650705ad6b90834906bd3ce08149e2528f28e > > > Diff: https://reviews.apache.org/r/64985/diff/1/ > > > Testing > ------- > > Used in blueprint cluster creation (on > `branch-feature-AMBARI-14714-blueprintv2` branch). > > > Thanks, > > Attila Doroszlai > >
