----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64976/#review194927 -----------------------------------------------------------
Ship it! Ship It! ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/DocumentExportProperties.java Lines 35 (patched) <https://reviews.apache.org/r/64976/#comment274013> mostly in ambari code, we are not using * in imports (convention) - Oliver Szabo On Jan. 5, 2018, 2:43 p.m., Krisztian Kasa wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64976/ > ----------------------------------------------------------- > > (Updated Jan. 5, 2018, 2:43 p.m.) > > > Review request for Ambari, Attila Doroszlai, Oliver Szabo, and Sid Wagle. > > > Bugs: AMBARI-22731 > https://issues.apache.org/jira/browse/AMBARI-22731 > > > Repository: ambari > > > Description > ------- > > * while arhiving documents from solr result files can be saved to hdfs > * s3 and hdfs releated parameters can be overwritten using infra manger api > * destination directory name contains the interval end value when archiving > to local filesystem > * job can be restarted using infra manger api > * bugfix: infra manger startup failed when no jobs were defined in the > properties > * IT: test for archiving to hdfs > * IT: test for archiving to local filesystem > * vagrant-infra-manager.properties file for integration testing with an > ambari installed cluster > > > Diffs > ----- > > ambari-infra/ambari-infra-manager-it/pom.xml 97e8ea0f44 > > ambari-infra/ambari-infra-manager-it/src/test/java/org/apache/ambari/infra/InfraClient.java > 0e391a3e6e > > ambari-infra/ambari-infra-manager-it/src/test/java/org/apache/ambari/infra/steps/AbstractInfraSteps.java > f48d4c2b49 > > ambari-infra/ambari-infra-manager-it/src/test/java/org/apache/ambari/infra/steps/ExportJobsSteps.java > 22826a01fc > > ambari-infra/ambari-infra-manager-it/src/test/resources/stories/infra_api_tests.story > 1044258816 > ambari-infra/ambari-infra-manager/docker/docker-compose.yml 1172631917 > ambari-infra/ambari-infra-manager/docker/infra-manager-docker-compose.sh > 6ddb7c292a > ambari-infra/ambari-infra-manager/pom.xml de131b03f6 > > ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/JobProperties.java > 0841dd7fd9 > > ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/DocumentArchivingConfiguration.java > 7588b9992a > > ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/DocumentExportProperties.java > 1484eedfe3 > > ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/ExportDestination.java > PRE-CREATION > > ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/FileNameSuffixFormatter.java > af48ab9aaa > > ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/HdfsUploader.java > PRE-CREATION > > ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/deleting/DocumentDeletingConfiguration.java > 4fce4b677f > > ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobExecutionRestartRequest.java > 88687e7260 > > ambari-infra/ambari-infra-manager/src/main/resources/infra-manager.properties > 9103d09e7e > > ambari-infra/ambari-infra-manager/src/test/java/org/apache/ambari/infra/job/JobPropertiesTest.java > 6a7622954f > > ambari-infra/ambari-infra-manager/src/test/java/org/apache/ambari/infra/job/archive/FileNameSuffixFormatterTest.java > 34e679f298 > > ambari-infra/ambari-infra-manager/src/test/resoruces/vagrant-infra-manager.properties > PRE-CREATION > ambari-infra/pom.xml 9e7a71bfa7 > > > Diff: https://reviews.apache.org/r/64976/diff/1/ > > > Testing > ------- > > * unit tests > * integration test using docker > * integration test using vagrant, ambari and ide > > > Thanks, > > Krisztian Kasa > >
