> On June 3, 2014, 1:11 p.m., Maxim Khutornenko wrote:
> > src/main/python/apache/aurora/client/cli/__init__.py, line 401
> > <https://reviews.apache.org/r/22207/diff/2/?file=602987#file602987line401>
> >
> >     What about SystemExit? Should not that be trapped here as well?

No - in clientv2, you're supposed to use the CommandException mechanisms to 
provide a proper return value. Throwing a SystemExit is an error - and so it 
should get caught by the universal exception handler and turned into an 
EXIT_UNKNOWN_ERROR.


- Mark


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22207/#review44640
-----------------------------------------------------------


On June 3, 2014, 1:07 p.m., Mark Chu-Carroll wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22207/
> -----------------------------------------------------------
> 
> (Updated June 3, 2014, 1:07 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Maxim Khutornenko.
> 
> 
> Bugs: aurora-497
>     https://issues.apache.org/jira/browse/aurora-497
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Prevent keyboard interrupts from spewing stack dumps.
> 
> (Also, cleanup python isort failures.)
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/cli/__init__.py 
> fd6f96ebe4acd358409f145178ebf8ad5ea27d05 
>   src/main/python/apache/aurora/client/cli/client.py 
> 1fb5364894d230646592942434eb1da6554d5c05 
>   src/main/python/apache/aurora/client/cli/config.py 
> 034c68e52ac8d2fbabb9dbf4f397f1a4920d0122 
>   src/main/python/apache/aurora/client/cli/cron.py 
> c30a0a605412229f3e4cddbe8c5ae746f256e30c 
>   src/test/python/apache/aurora/client/api/test_sla.py 
> 9c3bb6d386abbdbbfa8746639798ddca01d54fe9 
>   src/test/python/apache/aurora/client/cli/test_config_noun.py 
> 7a9d733835e204bfd179e698bc335435b837d24b 
>   src/test/python/apache/aurora/client/cli/test_create.py 
> b186b52416a2fae8de28fd1d21e7eec07fea8e55 
>   src/test/python/apache/aurora/client/cli/test_cron.py 
> 049405a4323fc73102d6ac1dae2230be4325c530 
>   src/test/python/apache/aurora/client/test_config.py 
> 4b3e1499c7447792288f4b480cbd756c8e19a831 
>   src/test/sh/org/apache/aurora/e2e/http_example.py 
> 04f7fa5c9bf36a36b395d870db02b97f8e5b6c66 
> 
> Diff: https://reviews.apache.org/r/22207/diff/
> 
> 
> Testing
> -------
> 
> Added a new test of interrupt, and ran all client tests.
> 
> 
> Thanks,
> 
> Mark Chu-Carroll
> 
>

Reply via email to