> On March 27, 2015, 6:09 p.m., Joshua Cohen wrote: > > src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroKerberosAuthenticationFilterTest.java, > > line 42 > > <https://reviews.apache.org/r/32559/diff/2/?file=907398#file907398line42> > > > > It feels like most of this stuff can be tested directly with a mock > > request/response/chain rather than starting up an http server. > > > > I think it's good to have integration tests for this as well, but we > > can probably simplify those to test the happy/sad path for integration > > tests and save testing all the corners for the unit test with mocks. > > Kevin Sweeney wrote: > As written the class under test has 100% coverage with this integration > test. (I actually found the IT easier to write since I have access to > ClientBuilder, rather than mocking HttpServletRequest/HttpServletResponse > methods)
My main concern (and it's not a major one) is that having each test case spin up an HTTP server can slow things down versus pure unit tests. In my experience these things can stack up and make running tests more painful than they need to be. - Joshua ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32559/#review78075 ----------------------------------------------------------- On March 27, 2015, 7:48 p.m., Kevin Sweeney wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32559/ > ----------------------------------------------------------- > > (Updated March 27, 2015, 7:48 p.m.) > > > Review request for Aurora, Joshua Cohen and Bill Farner. > > > Bugs: AURORA-812 > https://issues.apache.org/jira/browse/AURORA-812 > > > Repository: aurora > > > Description > ------- > > Support authenticating to the scheduler API with Kerberos. > > > Diffs > ----- > > config/findbugs/excludeFilter.xml 5ff5f87d6bb7d8bf3d9ecb1bc6c6b1a524d1bf15 > examples/vagrant/provision-dev-cluster.sh > ae500436e703140065e5c16fc0e38dbe3214e69f > examples/vagrant/upstart/aurora-scheduler-kerberos.conf PRE-CREATION > > src/main/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityModule.java > ec6a02c4086ee0d5a7529083030d978ea889f677 > > src/main/java/org/apache/aurora/scheduler/http/api/security/AuthorizeHeaderToken.java > PRE-CREATION > > src/main/java/org/apache/aurora/scheduler/http/api/security/IniShiroRealmModule.java > 58b559e96402ef282dc0e5ac2de0930906256487 > > src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5Realm.java > PRE-CREATION > > src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModule.java > PRE-CREATION > > src/main/java/org/apache/aurora/scheduler/http/api/security/KerberosPrincipalParser.java > PRE-CREATION > > src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroKerberosAuthenticationFilter.java > PRE-CREATION > src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroUtils.java > PRE-CREATION > > src/main/resources/org/apache/aurora/scheduler/http/api/security/jaas.conf.st > PRE-CREATION > > src/test/java/org/apache/aurora/scheduler/http/api/security/AuthorizeHeaderTokenTest.java > PRE-CREATION > > src/test/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModuleTest.java > PRE-CREATION > > src/test/java/org/apache/aurora/scheduler/http/api/security/KerberosPrincipalParserTest.java > PRE-CREATION > > src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroKerberosAuthenticationFilterTest.java > PRE-CREATION > src/test/sh/org/apache/aurora/e2e/test_kerberos_end_to_end.sh PRE-CREATION > > Diff: https://reviews.apache.org/r/32559/diff/ > > > Testing > ------- > > ./gradlew -Pq build > ./src/test/sh/org/apache/aurora/test_kerberos_end_to_end.sh > > > Thanks, > > Kevin Sweeney > >
