> On Feb. 17, 2015, 1:09 p.m., Kevin Sweeney wrote:
> > This is great! If this is gonna be mainline and not "contrib", how would 
> > you feel about adding some tests for this to Jenkins so that reviewbot can 
> > check this? You should be able to edit build-support/jenkins/build.sh. The 
> > Jenkins slaves have docker available so it should be possible to run in a 
> > target environment.

Adding CI checks is a good idea; I'll get something like that together and send 
another patch in a bit.

Sorry for the long update delay here - I was super busy with other things for a 
while, but want to try to get this finished soon :-)


> On Feb. 17, 2015, 1:09 p.m., Kevin Sweeney wrote:
> > debian/control, line 15
> > <https://reviews.apache.org/r/31101/diff/1/?file=865305#file865305line15>
> >
> >     https

Fixed.


> On Feb. 17, 2015, 1:09 p.m., Kevin Sweeney wrote:
> > debian/control, line 27
> > <https://reviews.apache.org/r/31101/diff/1/?file=865305#file865305line27>
> >
> >     "Aurora is a service scheduler..."
> >     
> >     here and below

Fixed.


> On Feb. 17, 2015, 1:09 p.m., Kevin Sweeney wrote:
> > debian/embed-runner-in-executor.py, line 1
> > <https://reviews.apache.org/r/31101/diff/1/?file=865307#file865307line1>
> >
> >     Any chance we can merge this with the vagrant build script or share 
> > this snippet of code between them some way?

Yes, that's probably wise.  I moved this script into the build-support 
directory (is that a good place for it?) and will have aurorabuild.sh call the 
same.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31101/#review72785
-----------------------------------------------------------


On Feb. 16, 2015, 4:20 p.m., Benjamin Staffin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31101/
> -----------------------------------------------------------
> 
> (Updated Feb. 16, 2015, 4:20 p.m.)
> 
> 
> Review request for Aurora and Jake Farrell.
> 
> 
> Bugs: AURORA-951
>     https://issues.apache.org/jira/browse/AURORA-951
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Native Debian packaging for Aurora
> 
> This uses Debian package dependencies to install gradle and thrift-compiler.  
> Gradle 2.2.1 isn't in Debian or Ubuntu yet, but you can build your own 
> package easily enough using https://github.com/benley/gradle-packaging
> 
> 
> Diffs
> -----
> 
>   debian/aurora-doc.docs PRE-CREATION 
>   debian/aurora-doc.examples PRE-CREATION 
>   debian/aurora-executor.dirs PRE-CREATION 
>   debian/aurora-executor.install PRE-CREATION 
>   debian/aurora-executor.links PRE-CREATION 
>   debian/aurora-executor.thermos.default PRE-CREATION 
>   debian/aurora-executor.thermos.init PRE-CREATION 
>   debian/aurora-executor.thermos.upstart PRE-CREATION 
>   debian/aurora-scheduler.default PRE-CREATION 
>   debian/aurora-scheduler.init PRE-CREATION 
>   debian/aurora-scheduler.install PRE-CREATION 
>   debian/aurora-scheduler.links PRE-CREATION 
>   debian/aurora-scheduler.postinst PRE-CREATION 
>   debian/aurora-scheduler.upstart PRE-CREATION 
>   debian/aurora-tools.install PRE-CREATION 
>   debian/aurora-tools.links PRE-CREATION 
>   debian/changelog PRE-CREATION 
>   debian/clusters.json PRE-CREATION 
>   debian/compat PRE-CREATION 
>   debian/control PRE-CREATION 
>   debian/copyright PRE-CREATION 
>   debian/embed-runner-in-executor.py PRE-CREATION 
>   debian/pants.ini PRE-CREATION 
>   debian/rules PRE-CREATION 
>   debian/source/format PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/31101/diff/
> 
> 
> Testing
> -------
> 
> Built debs in a clean Ubuntu 14.04 environment using git-buildpackage and 
> pbuilder. Have been using debs built from this branch on a testing cluster 
> for a few months now.
> 
> 
> Thanks,
> 
> Benjamin Staffin
> 
>

Reply via email to