> On March 2, 2015, 7:19 p.m., Jake Farrell wrote:
> > debian/aurora-executor.thermos.default, line 1
> > <https://reviews.apache.org/r/31101/diff/1/?file=865291#file865291line1>
> >
> >     needs license header

Fixed.


> On March 2, 2015, 7:19 p.m., Jake Farrell wrote:
> > debian/aurora-executor.thermos.init, line 1
> > <https://reviews.apache.org/r/31101/diff/1/?file=865292#file865292line1>
> >
> >     Needs license header

Fixed.


> On March 2, 2015, 7:19 p.m., Jake Farrell wrote:
> > debian/aurora-scheduler.default, line 1
> > <https://reviews.apache.org/r/31101/diff/1/?file=865294#file865294line1>
> >
> >     needs license header

Fixed


> On March 2, 2015, 7:19 p.m., Jake Farrell wrote:
> > debian/aurora-scheduler.init, line 1
> > <https://reviews.apache.org/r/31101/diff/1/?file=865295#file865295line1>
> >
> >     needs license header

Fixed.


> On March 2, 2015, 7:19 p.m., Jake Farrell wrote:
> > debian/aurora-scheduler.postinst, line 1
> > <https://reviews.apache.org/r/31101/diff/1/?file=865298#file865298line1>
> >
> >     needs license header

Fixed.


> On March 2, 2015, 7:19 p.m., Jake Farrell wrote:
> > debian/rules, line 1
> > <https://reviews.apache.org/r/31101/diff/1/?file=865309#file865309line1>
> >
> >     needs license header

Fixed.


> On March 2, 2015, 7:19 p.m., Jake Farrell wrote:
> > debian/embed-runner-in-executor.py, line 1
> > <https://reviews.apache.org/r/31101/diff/1/?file=865307#file865307line1>
> >
> >     if we keep this file then it needs license header added

Fixed - and moved into the build-support dir.


On March 2, 2015, 7:19 p.m., Benjamin Staffin wrote:
> > Bunch of files missing license headers as notes, but overall looks good. 
> > Would be nice to not have to put this at the top level, as wfarner pointed 
> > out also, but then would have to deal with symlinking and juggling to make 
> > it work (we did this in thrift before moving to the top level for ease). 
> > Would be good to wrap creation into a task that executed dch and dpkg 
> > commands all in one call

Yeah, as mentioned in a comment above, it's possible to do things like that at 
the cost of added build gymnastics.  What do you think about the idea of gradle 
creating a debian source package?  I'd prefer to do that in a separate review 
if possible.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31101/#review74880
-----------------------------------------------------------


On Feb. 16, 2015, 4:20 p.m., Benjamin Staffin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31101/
> -----------------------------------------------------------
> 
> (Updated Feb. 16, 2015, 4:20 p.m.)
> 
> 
> Review request for Aurora and Jake Farrell.
> 
> 
> Bugs: AURORA-951
>     https://issues.apache.org/jira/browse/AURORA-951
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Native Debian packaging for Aurora
> 
> This uses Debian package dependencies to install gradle and thrift-compiler.  
> Gradle 2.2.1 isn't in Debian or Ubuntu yet, but you can build your own 
> package easily enough using https://github.com/benley/gradle-packaging
> 
> 
> Diffs
> -----
> 
>   debian/aurora-doc.docs PRE-CREATION 
>   debian/aurora-doc.examples PRE-CREATION 
>   debian/aurora-executor.dirs PRE-CREATION 
>   debian/aurora-executor.install PRE-CREATION 
>   debian/aurora-executor.links PRE-CREATION 
>   debian/aurora-executor.thermos.default PRE-CREATION 
>   debian/aurora-executor.thermos.init PRE-CREATION 
>   debian/aurora-executor.thermos.upstart PRE-CREATION 
>   debian/aurora-scheduler.default PRE-CREATION 
>   debian/aurora-scheduler.init PRE-CREATION 
>   debian/aurora-scheduler.install PRE-CREATION 
>   debian/aurora-scheduler.links PRE-CREATION 
>   debian/aurora-scheduler.postinst PRE-CREATION 
>   debian/aurora-scheduler.upstart PRE-CREATION 
>   debian/aurora-tools.install PRE-CREATION 
>   debian/aurora-tools.links PRE-CREATION 
>   debian/changelog PRE-CREATION 
>   debian/clusters.json PRE-CREATION 
>   debian/compat PRE-CREATION 
>   debian/control PRE-CREATION 
>   debian/copyright PRE-CREATION 
>   debian/embed-runner-in-executor.py PRE-CREATION 
>   debian/pants.ini PRE-CREATION 
>   debian/rules PRE-CREATION 
>   debian/source/format PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/31101/diff/
> 
> 
> Testing
> -------
> 
> Built debs in a clean Ubuntu 14.04 environment using git-buildpackage and 
> pbuilder. Have been using debs built from this branch on a testing cluster 
> for a few months now.
> 
> 
> Thanks,
> 
> Benjamin Staffin
> 
>

Reply via email to