> On March 31, 2015, 7:30 p.m., Kevin Sweeney wrote:
> > src/main/python/apache/aurora/common/auth/__init__.py, line 14
> > <https://reviews.apache.org/r/32541/diff/2/?file=909512#file909512line14>
> >
> >     I see red here but I don't see any corresponding changes to import 
> > lines - were these completely unused?
> >     
> >     This change will require changing lines of the form
> >     
> >     ```py
> >     from apache.aurora.common.auth import AuthModule
> >     ```
> >     
> >     to
> >     
> >     ```py
> >     from apache.aurora.common.auth.auth_module import AuthModule
> >     ```

Correct, nothing was actually referencing AuthModule. The only adjustment I had 
to make was for the auth_module_manager.


> On March 31, 2015, 7:30 p.m., Kevin Sweeney wrote:
> > src/main/python/apache/aurora/common/auth/auth_kerberos.py, line 25
> > <https://reviews.apache.org/r/32541/diff/2/?file=909513#file909513line25>
> >
> >     does mechanism also need to be overridden?

Does not have to as long as the prod module is still using the same auth 
mechanism.


> On March 31, 2015, 7:30 p.m., Kevin Sweeney wrote:
> > src/main/python/apache/aurora/common/auth/auth_module_manager.py, line 65
> > <https://reviews.apache.org/r/32541/diff/2/?file=909515#file909515line65>
> >
> >     nit: rather than abbreviate as auth we should be explicit that that 
> > this references authentication (as opposed to authorization).

I think "auth" is quite commonly used for "authentication". I'll defer the full 
use for authorization (or "authz") instead.


> On March 31, 2015, 7:30 p.m., Kevin Sweeney wrote:
> > src/main/python/apache/aurora/common/auth/auth_module.py, line 38
> > <https://reviews.apache.org/r/32541/diff/2/?file=909514#file909514line38>
> >
> >     This should reference
> >     
> >     ```py
> >     """
> >     :rtype: requests.auth.AuthBase
> >     """
> >     ```

Good idea. Added type validation into transport.py.


> On March 31, 2015, 7:30 p.m., Kevin Sweeney wrote:
> > src/test/python/apache/aurora/client/api/test_scheduler_client.py, line 391
> > <https://reviews.apache.org/r/32541/diff/2/?file=909516#file909516line391>
> >
> >     this should fail - the argument should subclass requests.auth.AuthBase.

This still passes, I have added type validation in transport.py.


- Maxim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32541/#review78390
-----------------------------------------------------------


On March 30, 2015, 9:09 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32541/
> -----------------------------------------------------------
> 
> (Updated March 30, 2015, 9:09 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Brian Wickman.
> 
> 
> Bugs: AURORA-813
>     https://issues.apache.org/jira/browse/AURORA-813
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> First take on client kerberos support. The idea is to repurpose the existing 
> auth_module system to support both legacy and kerberos during the deprecation 
> period. This way the 0.8.0 client will be able to talk to pre-0.8.0 scheduler 
> and use SessionKey-based authorization. Later (in 0.9.0), the payload() will 
> be removed along with SessionKey (AURORA-1229). That will let us get rid of 
> SchedulerProxy (or reduce it substantially). The auth_module might stay 
> though to support other auth plugins (e.g. requests-ntlm or 
> requests-oauthlib).
> 
> TODO: integration e2e tests once scheduler side lands.
> 
> 
> Diffs
> -----
> 
>   3rdparty/python/requirements.txt 11a307cdb476ebcc25ab5c6b555bed29241ea988 
>   src/main/python/apache/aurora/client/api/__init__.py 
> a81329f6f947bbea4001c3a521c1923410a51eab 
>   src/main/python/apache/aurora/client/api/scheduler_client.py 
> 95e553427492407743dcac31d70f392a7c1bbc02 
>   src/main/python/apache/aurora/client/cli/BUILD 
> c6b4e8a09d1315cf5defee2155a6e0c697892a30 
>   src/main/python/apache/aurora/client/cli/client.py 
> 24516d114db1743cdf600c542a27fcf5b68053a0 
>   src/main/python/apache/aurora/common/auth/BUILD 
> 966484627dab90e7606f1fc638cd0e159aee3317 
>   src/main/python/apache/aurora/common/auth/__init__.py 
> 3119fd63d3dfa28f93f219b23030059580fed098 
>   src/main/python/apache/aurora/common/auth/auth_kerberos.py PRE-CREATION 
>   src/main/python/apache/aurora/common/auth/auth_module.py 
> 5f4116ef4cfbc407e0c50dc938870fb14e2299b4 
>   src/main/python/apache/aurora/common/auth/auth_module_manager.py 
> 73a8e5cd51edf694b971cd2c298ff406aff8c6d7 
>   src/test/python/apache/aurora/client/api/test_scheduler_client.py 
> 0a6194831c332a96eab62b869c4e05cfa9def058 
> 
> Diff: https://reviews.apache.org/r/32541/diff/
> 
> 
> Testing
> -------
> 
> ./pants test.pytest --no-fast src/test/python:all
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Reply via email to