-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32802/#review78756
-----------------------------------------------------------


This patch does not apply cleanly on master (a7b95d9), do you need to rebase?

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On April 3, 2015, 1:43 a.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32802/
> -----------------------------------------------------------
> 
> (Updated April 3, 2015, 1:43 a.m.)
> 
> 
> Review request for Aurora and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> The first of several benchmarks to exercise the thrift API.  The real 
> motivation here is to have performance data to assess the impact of migrating 
> the task store to H2.  I'm targeting the `getRoleSummary` RPC specifically 
> here as i consider it the likely candidate to suffer.
> 
> One 'trick' i employed here was JSON for input parameters.  I took this 
> approach since i really wanted to explore specific axes of growth without the 
> full outer product of each individual parameters.
> 
> Some changes along the way:
> - upgraded to jmh 1.7.1
> - moved some JMH run configuration parameters out of the gradle config and 
> into benchmark classes.  This allows us to define run configurations for each 
> microbenchmark
> - changed the benchmark mode for existing and new tests to throughput.  We 
> had several benchmarks whose iteration time was measuring in hundreds of 
> microseconds, which is too high resolution to capture performance variation.  
> By running iterations for a set amount of time and counting iterations 
> accomplished, we can capture more reliable data.
> 
> 
> Diffs
> -----
> 
>   build.gradle 66dbdfde830c81c9b2291d2b8391f1ccac94b485 
>   src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java 
> 5309e8140fff411da30ee87c1b3b1a55d6fdaeeb 
>   src/jmh/java/org/apache/aurora/benchmark/Tasks.java 
> 491c6871ba7a4c76a4eb084afb2627a3f93db8df 
>   src/jmh/java/org/apache/aurora/benchmark/ThriftApiBenchmarks.java 
> PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/thrift/ThriftModule.java 
> c65e0218211b797ad50e2ac62e71136f967e5f5d 
> 
> Diff: https://reviews.apache.org/r/32802/diff/
> 
> 
> Testing
> -------
> 
> Will post jmh output shortly.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Reply via email to