-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32900/#review79052
-----------------------------------------------------------

Ship it!


Master (5587bce) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On April 6, 2015, 8:30 p.m., Zameer Manji wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32900/
> -----------------------------------------------------------
> 
> (Updated April 6, 2015, 8:30 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This is a refactor of AuroraCommandContext which removes all url related 
> methods out of it. The objective of this refactor is to remove functionality 
> from AuroraCommandContext to allow for easier testing of commands. This 
> commit also adds two tests for commands which were using the url related 
> functionality but lacked test coverage.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/base.py 
> 0c8e97e0b26b0c4ede77873eaae76ebe7bf36a4a 
>   src/main/python/apache/aurora/client/cli/context.py 
> 51c7d24dca664e476e62f1864d095416dfab70e4 
>   src/main/python/apache/aurora/client/cli/cron.py 
> 3416c8e1932056725880f2007b60d77112759428 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> 8f349c09637c16e2499e85f2dc96eb7ccffd0aaf 
>   src/main/python/apache/aurora/client/cli/update.py PRE-CREATION 
>   src/test/python/apache/aurora/client/cli/test_create.py 
> 31fa56f5edcfc97903725ab27ccc12c6a8f39ffc 
>   src/test/python/apache/aurora/client/cli/test_cron.py 
> f488432cd68cc68fab8fce968e8605625ea3f56a 
>   src/test/python/apache/aurora/client/cli/test_kill.py 
> e3a366bf67074e50787394cad58d5e01359b641e 
>   src/test/python/apache/aurora/client/cli/test_open.py 
> c20649f5cada241d0f6e9ae5f88d300eac073517 
>   src/test/python/apache/aurora/client/cli/test_restart.py 
> 92aefe612dd59df75188fd7fc8cf080c9a878dde 
>   src/test/python/apache/aurora/client/cli/util.py 
> 95a2123e127c9811fd2305e71cfc5c7c4376f904 
> 
> Diff: https://reviews.apache.org/r/32900/diff/
> 
> 
> Testing
> -------
> 
> ./pants test.pytest --no-fast src/test/python/apache/aurora/client/cli::
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Reply via email to