-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32973/#review79398
-----------------------------------------------------------



src/test/python/apache/aurora/executor/test_thermos_task_runner.py
<https://reviews.apache.org/r/32973/#comment128708>

    Is this really necessary? IMHO, from the perspective of the runner, you can 
assume that the HttpSignaler class is tested and functioning correctly. Mocking 
the HttpSignaler should therfore be sufficient.


- Stephan Erb


On April 8, 2015, 5:51 p.m., Brian Brazil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32973/
> -----------------------------------------------------------
> 
> (Updated April 8, 2015, 5:51 p.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add unittests for /quitquitquit.
> Fix name of test for sigterm being ignored.
> 
> Based on 
> https://github.com/tellapart/incubator-aurora/commit/c90532d69d69045c545004451e3660f5282e6e34
> 
> 
> Diffs
> -----
> 
>   docs/configuration-reference.md fb753ead94fcd1ed76352306391d356652934a4e 
>   src/main/python/apache/aurora/common/http_signaler.py 
> 531f1fecbcbf8015175c7f1cb1e1c4d3e7d1268a 
>   src/main/python/apache/aurora/executor/thermos_task_runner.py 
> 505a1e69ebfe1bd2fa74623063cb923ecff8a021 
>   src/main/python/apache/thermos/config/schema_base.py 
> f9143cc1b83143d6147f59d90c79435d055d0518 
>   src/test/python/apache/aurora/common/test_http_signaler.py 
> c6a21708eb997f213f4cca038891a84f6c5218d4 
>   src/test/python/apache/aurora/executor/test_thermos_task_runner.py 
> 6b24bbb2ab7ca16f97961aabeed945b61e5b5908 
> 
> Diff: https://reviews.apache.org/r/32973/diff/
> 
> 
> Testing
> -------
> 
> Unittests and manually in vagrant cluster.
> 
> 
> Thanks,
> 
> Brian Brazil
> 
>

Reply via email to