> On April 10, 2015, 10:52 p.m., Kevin Sweeney wrote:
> > src/main/python/apache/aurora/client/api/scheduler_client.py, line 32
> > <https://reviews.apache.org/r/32541/diff/6/?file=924005#file924005line32>
> >
> >     nit: trailing comma here

Done.


> On April 10, 2015, 10:52 p.m., Kevin Sweeney wrote:
> > src/main/python/apache/aurora/common/auth/BUILD, line 30
> > <https://reviews.apache.org/r/32541/diff/6/?file=924008#file924008line30>
> >
> >     rename this target to match its module name?

I thought about that but "kerberos" seemed too generic. I am ok renaming it 
though.


> On April 10, 2015, 10:52 p.m., Kevin Sweeney wrote:
> > src/main/python/apache/aurora/common/auth/auth_module_manager.py, line 68
> > <https://reviews.apache.org/r/32541/diff/6/?file=924011#file924011line68>
> >
> >     Does this work in the non-kerberized client? Don't see anything calling 
> > register_auth_module()

There is already a default UNAUTHENTICATED module registered above, which 
prevents this error in unsecure client.


> On April 10, 2015, 10:52 p.m., Kevin Sweeney wrote:
> > src/main/python/apache/aurora/common/transport.py, line 57
> > <https://reviews.apache.org/r/32541/diff/6/?file=924013#file924013line57>
> >
> >     missing a :type auth: doc - should be on separate line
> >     
> >     see 
> > https://www.jetbrains.com/pycharm/help/type-hinting-in-pycharm.html#d269326e180

Done.


- Maxim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32541/#review79766
-----------------------------------------------------------


On April 10, 2015, 10:45 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32541/
> -----------------------------------------------------------
> 
> (Updated April 10, 2015, 10:45 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Brian Wickman.
> 
> 
> Bugs: AURORA-813
>     https://issues.apache.org/jira/browse/AURORA-813
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> First take on client kerberos support. The idea is to repurpose the existing 
> auth_module system to support both legacy and kerberos during the deprecation 
> period. This way the 0.8.0 client will be able to talk to pre-0.8.0 scheduler 
> and use SessionKey-based authorization. Later (in 0.9.0), the payload() will 
> be removed along with SessionKey (AURORA-1229). That will let us get rid of 
> SchedulerProxy (or reduce it substantially). The auth_module might stay 
> though to support other auth plugins (e.g. requests-ntlm or 
> requests-oauthlib).
> 
> TODO: integration e2e tests once scheduler side lands.
> 
> 
> Diffs
> -----
> 
>   3rdparty/python/requirements.txt 11a307cdb476ebcc25ab5c6b555bed29241ea988 
>   examples/vagrant/aurorabuild.sh f11488a3bd04c300e2772831c4926de75053eb3f 
>   examples/vagrant/clusters_kerberos.json PRE-CREATION 
>   examples/vagrant/upstart/aurora-scheduler-kerberos.conf 
> 0a809e8e0301fdb825d0d50ab2c636522fea9163 
>   src/main/python/apache/aurora/admin/BUILD 
> c51a90b08efa39e517c1ae06fe53daa013c94971 
>   src/main/python/apache/aurora/admin/aurora_admin.py 
> f9e8f3d19a2d861cd20aaba88455579cd8fd22ee 
>   src/main/python/apache/aurora/client/api/__init__.py 
> a81329f6f947bbea4001c3a521c1923410a51eab 
>   src/main/python/apache/aurora/client/api/scheduler_client.py 
> 95e553427492407743dcac31d70f392a7c1bbc02 
>   src/main/python/apache/aurora/client/cli/BUILD 
> 3ab41cc26b04371e7df09983ff4c4d003988cd28 
>   src/main/python/apache/aurora/client/cli/client.py 
> 24516d114db1743cdf600c542a27fcf5b68053a0 
>   src/main/python/apache/aurora/common/auth/BUILD 
> 966484627dab90e7606f1fc638cd0e159aee3317 
>   src/main/python/apache/aurora/common/auth/__init__.py 
> 3119fd63d3dfa28f93f219b23030059580fed098 
>   src/main/python/apache/aurora/common/auth/auth_module.py 
> 5f4116ef4cfbc407e0c50dc938870fb14e2299b4 
>   src/main/python/apache/aurora/common/auth/auth_module_manager.py 
> 73a8e5cd51edf694b971cd2c298ff406aff8c6d7 
>   src/main/python/apache/aurora/common/auth/kerberos.py PRE-CREATION 
>   src/main/python/apache/aurora/common/transport.py 
> 395f8a94d9a27aad00166a17f2528a8c0833ffdd 
>   src/test/python/apache/aurora/client/api/test_scheduler_client.py 
> 0a6194831c332a96eab62b869c4e05cfa9def058 
>   src/test/python/apache/aurora/common/test_transport.py 
> b78e0b3badfbbeecefff7b5954f3796cef4da9d8 
>   src/test/sh/org/apache/aurora/e2e/test_kerberos_end_to_end.sh 
> 47d22eeacef06c999dda984f6d1ed22e5ab0c417 
> 
> Diff: https://reviews.apache.org/r/32541/diff/
> 
> 
> Testing
> -------
> 
> ./pants test.pytest --no-fast src/test/python:all
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Reply via email to