> On April 9, 2015, 2:29 a.m., Bill Farner wrote: > > Actually - can you add a benchmark to ThriftApiBenchmarks and include > > results in the description? Should be pretty easy to prove the improvement > > of this.
Done. - Maxim ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32990/#review79467 ----------------------------------------------------------- On April 8, 2015, 9:45 p.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32990/ > ----------------------------------------------------------- > > (Updated April 8, 2015, 9:45 p.m.) > > > Review request for Aurora and Bill Farner. > > > Bugs: AURORA-1263 > https://issues.apache.org/jira/browse/AURORA-1263 > > > Repository: aurora > > > Description > ------- > > Using event collections with "select" avoids unnecessary row explosion and > provdes subsecond execution time for a large job update that used to take > half a minute. > > > Diffs > ----- > > > src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml > 4536cd35ffc231a5d2f6c1b5bf2aaa084ce3ad1d > > Diff: https://reviews.apache.org/r/32990/diff/ > > > Testing > ------- > > ./gradlew -Pq build > Manual testing in vagrant. > > > Thanks, > > Maxim Khutornenko > >
