----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33184/ -----------------------------------------------------------
(Updated April 14, 2015, 9:18 p.m.) Review request for Aurora. Changes ------- Test inequality explicitly. Repository: aurora Description ------- Implement missing != operator for AuroraJobKey >From the Python docu of __ne__: "There are no implied relationships among the >comparison operators. The truth of x==y does not imply that x!=y is false. >Accordingly, when defining __eq__(), one should also define __ne__() so that >the operators will behave as expected." Diffs (updated) ----- src/main/python/apache/aurora/common/aurora_job_key.py 88896c6c41235f44447d313f0d77682acdca7cce src/test/python/apache/aurora/common/test_aurora_job_key.py 7d8d58b541f16d63495f46b58bd928e8f53f66d1 Diff: https://reviews.apache.org/r/33184/diff/ Testing ------- ./pants test.pytest --no-fast --options=-v src/test/python/apache/aurora/common:: Thanks, Stephan Erb
