-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32907/#review80089
-----------------------------------------------------------

Ship it!


I'm a little hazy on the scope of our performance benchmarks, but do they cover 
the changes in this patch? If so I think the commit should include benchmark 
information.


src/test/java/org/apache/aurora/scheduler/async/preemptor/BiCacheTest.java
<https://reviews.apache.org/r/32907/#comment129854>

    Please test the stat value in the other tests as well.


- Zameer Manji


On April 14, 2015, 11:17 a.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32907/
> -----------------------------------------------------------
> 
> (Updated April 14, 2015, 11:17 a.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Bugs: AURORA-1219
>     https://issues.apache.org/jira/browse/AURORA-1219
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Current preemption model assumes tracking preemption slots/reservations by 
> taskId. This reduces preemption efficiency as it only takes a specific taskId 
> scheduling round to claim the PreemptionSlot and then subsequently make a 
> slave reservation. 
> 
> This diff generalizes the preemption pool by TaskGroupKey. Preemption slots 
> are now created and cached by TaskGroupKey and are available to _any_ task 
> from the same TaskGroup. 
> 
> This change should also simplify the algorithm in 
> https://reviews.apache.org/r/32597/.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 
> e87dda47a355654c66f6f54fb25a4d9a7f68422d 
>   src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java 
> ebc520ebb4dddbc69b2b4a6f9174c1451d61887a 
>   src/main/java/org/apache/aurora/scheduler/async/preemptor/BiCache.java 
> PRE-CREATION 
>   
> src/main/java/org/apache/aurora/scheduler/async/preemptor/PendingTaskProcessor.java
>  67ad5d7f9909bc892301c19586561b6cdbfe79e6 
>   
> src/main/java/org/apache/aurora/scheduler/async/preemptor/PreemptionSlotCache.java
>  b5a42a0a0498f06a382576e2c3a839bbb7f1d2b1 
>   src/main/java/org/apache/aurora/scheduler/async/preemptor/Preemptor.java 
> 77617ec11119a2bcd062d5b80cd2b4c58dc80514 
>   
> src/main/java/org/apache/aurora/scheduler/async/preemptor/PreemptorModule.java
>  1092c055588363794b37a965fb2f17a6e50d92d7 
>   src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java 
> b61abf93eb6bb7dee336a675546bc604612b130e 
>   src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java 
> 9c47a768ec9e5c527e7f2c50332ef77433c8e088 
>   src/test/java/org/apache/aurora/scheduler/async/preemptor/BiCacheTest.java 
> PRE-CREATION 
>   
> src/test/java/org/apache/aurora/scheduler/async/preemptor/PendingTaskProcessorTest.java
>  75fc16dd2796ef2d5eebea6575d141cf2a4fade0 
>   
> src/test/java/org/apache/aurora/scheduler/async/preemptor/PreemptionSlotCacheTest.java
>  80bd13a192bda64759b5a93749ec47ddfeae504a 
>   
> src/test/java/org/apache/aurora/scheduler/async/preemptor/PreemptorImplTest.java
>  97d6087ab92ae6d492f50ccf6c6091ec42b1c032 
> 
> Diff: https://reviews.apache.org/r/32907/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew -Pq build
> Manual testing in vagrant.
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Reply via email to