> On April 15, 2015, 10:49 p.m., Aurora ReviewBot wrote:
> > Master (b18dc44) is red with this patch.
> >   ./build-support/jenkins/build.sh
> > 
> > :compileJavaNote: Writing 
> > file:/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/classes/main/com/twitter/common/args/apt/cmdline.arg.info.txt.2
> > /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java:231:
> >  error: cannot find symbol
> >           driver.acknowledgeStatusUpdate(status);
> >                 ^
> >   symbol:   method acknowledgeStatusUpdate(TaskStatus)
> >   location: variable driver of type SchedulerDriver
> > /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java:250:
> >  error: cannot find symbol
> >     driver.acknowledgeStatusUpdate(status);
> >           ^
> >   symbol:   method acknowledgeStatusUpdate(TaskStatus)
> >   location: variable driver of type SchedulerDriver
> > /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/mesos/DriverFactoryImpl.java:39:
> >  error: no suitable constructor found for 
> > MesosSchedulerDriver(Scheduler,FrameworkInfo,String,boolean,Credential)
> >       return new MesosSchedulerDriver(scheduler, frameworkInfo, master, 
> > false, credentials.get());
> >              ^
> >     constructor 
> > MesosSchedulerDriver.MesosSchedulerDriver(Scheduler,FrameworkInfo,String,Credential)
> >  is not applicable
> >       (actual and formal argument lists differ in length)
> >     constructor 
> > MesosSchedulerDriver.MesosSchedulerDriver(Scheduler,FrameworkInfo,String) 
> > is not applicable
> >       (actual and formal argument lists differ in length)
> > /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/mesos/DriverFactoryImpl.java:41:
> >  error: no suitable constructor found for 
> > MesosSchedulerDriver(Scheduler,FrameworkInfo,String,boolean)
> >       return new MesosSchedulerDriver(scheduler, frameworkInfo, master, 
> > false);
> >              ^
> >     constructor 
> > MesosSchedulerDriver.MesosSchedulerDriver(Scheduler,FrameworkInfo,String,Credential)
> >  is not applicable
> >       (actual argument boolean cannot be converted to Credential by method 
> > invocation conversion)
> >     constructor 
> > MesosSchedulerDriver.MesosSchedulerDriver(Scheduler,FrameworkInfo,String) 
> > is not applicable
> >       (actual and formal argument lists differ in length)
> > 4 errors
> >  FAILED
> > 
> > FAILURE: Build failed with an exception.
> > 
> > * What went wrong:
> > Execution failed for task ':compileJava'.
> > > Compilation failed; see the compiler error output for details.
> > 
> > * Try:
> > Run with --stacktrace option to get the stack trace. Run with --info or 
> > --debug option to get more log output.
> > 
> > BUILD FAILED
> > 
> > Total time: 1 mins 21.608 secs
> > 
> > 
> > I will refresh this build result if you post a review containing 
> > "@ReviewBot retry"

Ah, I see reviewbot doesn't apply dependent patches.


- Ben


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33243/#review80276
-----------------------------------------------------------


On April 15, 2015, 10:47 p.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33243/
> -----------------------------------------------------------
> 
> (Updated April 15, 2015, 10:47 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-1228
>     https://issues.apache.org/jira/browse/AURORA-1228
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> The scheduler now explicitly acknowledges updates. I left the structure as 
> is, per Bill's suggestion.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/mesos/DriverFactoryImpl.java 
> db7aa74c2dfca3d520d978d7837d1f2639e6c05c 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java 
> f40746b5712f21e551c06eeb1aa379ebdcdbc693 
>   src/test/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImplTest.java 
> 4ef23ea6ebd2c9587a8356507fcb49a36b9de219 
> 
> Diff: https://reviews.apache.org/r/33243/diff/
> 
> 
> Testing
> -------
> 
> Ran the unit tests and the end-to-end test.
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>

Reply via email to