-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33243/#review80278
-----------------------------------------------------------


Looks like you forgot to git add build.gradle?


src/main/java/org/apache/aurora/scheduler/mesos/DriverFactoryImpl.java
<https://reviews.apache.org/r/33243/#comment130089>

    we typically will place a comment next to the parameter to indicate its 
name, but don't duplicate javadoc of APIs we're calling. In this case the 
comment is vague - consider annotating the parameter directly:
    
    ```java
    return new MesosSchedulerDriver(
      scheduler,
      frameworkInfo,
      master,
      false /* disable implicit acknowledgements */);
    ```
    
    instead. Also this probably escaped code review upstream but this would be 
a good place to use an enum instead of a boolean - consider filing an upstream 
ticket.



src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java
<https://reviews.apache.org/r/33243/#comment130090>

    This comment is now a lie - we are sure we've NACKed the status update.


- Kevin Sweeney


On April 15, 2015, 3:47 p.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33243/
> -----------------------------------------------------------
> 
> (Updated April 15, 2015, 3:47 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-1228
>     https://issues.apache.org/jira/browse/AURORA-1228
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> The scheduler now explicitly acknowledges updates. I left the structure as 
> is, per Bill's suggestion.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/mesos/DriverFactoryImpl.java 
> db7aa74c2dfca3d520d978d7837d1f2639e6c05c 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java 
> f40746b5712f21e551c06eeb1aa379ebdcdbc693 
>   src/test/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImplTest.java 
> 4ef23ea6ebd2c9587a8356507fcb49a36b9de219 
> 
> Diff: https://reviews.apache.org/r/33243/diff/
> 
> 
> Testing
> -------
> 
> Ran the unit tests and the end-to-end test.
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>

Reply via email to