----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33366/#review81055 -----------------------------------------------------------
Ship it! I'd like to note that our best practice is to use `mock.patch` sparingly, as it tends to suggest poorly-factored code and results in tests that can be difficult to reason about. However, since the observer may be overhauled in the not-too-distant future, a refactoring would not have been wise and i believe this is an appropriate use of patching. - Bill Farner On April 21, 2015, 7:53 p.m., Bhuvan Arumugam wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33366/ > ----------------------------------------------------------- > > (Updated April 21, 2015, 7:53 p.m.) > > > Review request for Aurora, Bill Farner and Zameer Manji. > > > Bugs: AURORA-1135 > https://issues.apache.org/jira/browse/AURORA-1135 > > > Repository: aurora > > > Description > ------- > > Download url for stdout/stderr broken Make it relative to sandbox. > > Testing Done: > ./pants test.pytest --no-fast --options='--verbose' src/test/python:: > > Bugs closed: AURORA-1135 > > > Diffs > ----- > > src/main/python/apache/thermos/observer/http/file_browser.py > 2f48594a87724b84bad7e149eb4d63c71ea954ee > src/test/python/apache/thermos/observer/http/BUILD PRE-CREATION > src/test/python/apache/thermos/observer/http/test_file_browser.py > PRE-CREATION > > Diff: https://reviews.apache.org/r/33366/diff/ > > > Testing > ------- > > > Thanks, > > Bhuvan Arumugam > >
