-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33537/#review81722
-----------------------------------------------------------


Overall LGTM.

Can you link to this page from `deploying-aurora-scheduler.md`?


docs/security.md
<https://reviews.apache.org/r/33537/#comment132148>

    A table of contents would be nice, and match other files.



docs/security.md
<https://reviews.apache.org/r/33537/#comment132147>

    The merits of strong passwords is not lost on me, but i don't think it 
should be the job of this document.  Noting that these are plaintext/raw is 
good, but beyond that i think it's out of scope.



docs/security.md
<https://reviews.apache.org/r/33537/#comment132152>

    Is an equivalent change to clusters.json needed for basic auth?  Even if 
not, it's worth calling out.



docs/security.md
<https://reviews.apache.org/r/33537/#comment132149>

    Markdown didn't like the format example here.


- Bill Farner


On April 24, 2015, 10:40 p.m., Kevin Sweeney wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33537/
> -----------------------------------------------------------
> 
> (Updated April 24, 2015, 10:40 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Bill Farner.
> 
> 
> Bugs: AURORA-817
>     https://issues.apache.org/jira/browse/AURORA-817
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> SSIA
> 
> A rendered version is available on github as 
> https://github.com/kevints/aurora/blob/kts/security-docs/docs/security.md - 
> feel free to send pull requests to fix typos, etc, from the markdown editor 
> there and I will incorporate them into this review.
> 
> 
> Diffs
> -----
> 
>   docs/security.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/33537/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>

Reply via email to