----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33456/#review81912 -----------------------------------------------------------
Ship it! I'll let you make the call here. I think the decorator methods decouple us from the implementations of [Scheduled]ExecutorService, and the code to do it is very mechanical. However, it will likely require ~200 lines of this wiring code, which i can understand is undesirable at present. - Bill Farner On April 22, 2015, 10:58 p.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33456/ > ----------------------------------------------------------- > > (Updated April 22, 2015, 10:58 p.m.) > > > Review request for Aurora and Bill Farner. > > > Repository: aurora > > > Description > ------- > > Our async EventBus is using a regular executor thus potentially hiding > unhandled errors. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/base/AsyncUtil.java > f657e057b5bbff69971876e104ff0e47b2dc4faa > src/main/java/org/apache/aurora/scheduler/events/PubsubEventModule.java > 3a4d40adc1abe170b5b80644db9f079751d8a9bf > src/test/java/org/apache/aurora/scheduler/base/AsyncUtilTest.java > e990f528aac768b5c9b829c9544045a831e094fe > > Diff: https://reviews.apache.org/r/33456/diff/ > > > Testing > ------- > > ./gradlew -Pq build > > > Thanks, > > Maxim Khutornenko > >
