> On April 29, 2015, 1:42 a.m., Maxim Khutornenko wrote:
> > src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java, line 
> > 106
> > <https://reviews.apache.org/r/33608/diff/2/?file=944570#file944570line106>
> >
> >     s/public/private

Done.


> On April 29, 2015, 1:42 a.m., Maxim Khutornenko wrote:
> > src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java, line 
> > 107
> > <https://reviews.apache.org/r/33608/diff/2/?file=944570#file944570line107>
> >
> >     requireNonNull() for both

Done.


> On April 29, 2015, 1:42 a.m., Maxim Khutornenko wrote:
> > src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java, line 
> > 132
> > <https://reviews.apache.org/r/33608/diff/2/?file=944570#file944570line132>
> >
> >     add newline before

Done. This is I think where braces on the next line help, but that ship has 
sailed :)

https://twitter.com/blundell_apps/status/593390700332453888


> On April 29, 2015, 1:42 a.m., Maxim Khutornenko wrote:
> > src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java, line 
> > 149
> > <https://reviews.apache.org/r/33608/diff/2/?file=944570#file944570line149>
> >
> >     drop

Done.


> On April 29, 2015, 1:42 a.m., Maxim Khutornenko wrote:
> > src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java, line 
> > 155
> > <https://reviews.apache.org/r/33608/diff/2/?file=944570#file944570line155>
> >
> >     s/protected/private/g

Done.


> On April 29, 2015, 1:42 a.m., Maxim Khutornenko wrote:
> > src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java, line 
> > 183
> > <https://reviews.apache.org/r/33608/diff/2/?file=944570#file944570line183>
> >
> >     Suggest inlining the anonymous Command instead.

Done.


> On April 29, 2015, 1:42 a.m., Maxim Khutornenko wrote:
> > src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java, line 
> > 169
> > <https://reviews.apache.org/r/33608/diff/2/?file=944570#file944570line169>
> >
> >     This is no longer going to work the way you expect given that the setup 
> > level is Trial now. You'd need to have a setter in your storage wrapper 
> > that will be called from a new handler with `Level.Iteration`.

Ah, I see that now. Ran it to make sure this was behaving as expected.


- Ben


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33608/#review81915
-----------------------------------------------------------


On April 29, 2015, 12:48 a.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33608/
> -----------------------------------------------------------
> 
> (Updated April 29, 2015, 12:48 a.m.)
> 
> 
> Review request for Aurora and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-1283
>     https://issues.apache.org/jira/browse/AURORA-1283
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> In order to justify doing asynchronous batch acknowledgements and to better 
> understand status update throughput, this introduces a benchmark.
> 
> Note that this assumes that status update processing is not synchronous, so 
> that the benchmark doesn't need to be updated for AURORA-1228.
> 
> 
> Diffs
> -----
> 
>   src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java 
> PRE-CREATION 
>   src/jmh/java/org/apache/aurora/benchmark/fakes/FakeCommand.java 
> PRE-CREATION 
>   src/jmh/java/org/apache/aurora/benchmark/fakes/FakeOfferManager.java 
> PRE-CREATION 
>   src/jmh/java/org/apache/aurora/benchmark/fakes/FakeSchedulerDriver.java 
> PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/UserTaskLauncher.java 
> c54619f7cd617b48069363173dcf63b6254b4095 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java 
> 9b8ab7c1027731f9d3f6cae77b85272ea63354d4 
>   src/main/java/org/apache/aurora/scheduler/mesos/SchedulerDriverModule.java 
> d7d659bb13f085ff06291ef0033572f8bdf29874 
> 
> Diff: https://reviews.apache.org/r/33608/diff/
> 
> 
> Testing
> -------
> 
> Ran the benchmarks against the existing code and some pending code I have for 
> AURORA-1228 to demonstrate the improvement.
> 
> The end to end tests are broken, appears to be unrelated to my change from 
> what I can tell.
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>

Reply via email to