> On May 7, 2015, 5:06 p.m., Jake Farrell wrote:
> > build-support/release/verify-release-candidate, line 70
> > <https://reviews.apache.org/r/33854/diff/3/?file=950636#file950636line70>
> >
> >     Not crazy about having multiple locations for gradle versions to be 
> > set, do we have to include gradle download here or could we just assume 
> > that gradle is all ready on the system as a build dependency
> 
> Jake Farrell wrote:
>     +1 to the patch other than the gradle download, since we all ready depend 
> on vagrant in the e2e test done see why we cant make gradle a similar 
> required dependency
> 
> Bill Farner wrote:
>     The issue becomes the current strict gradle version check.  I will change 
> the gradle version check to be less strict, which will make me comfortable 
> with using the system-installed gradle here.
> 
> Kevin Sweeney wrote:
>     This is a complete duplication of the gradle wrapper. Is there a way we 
> can include this standard tool rather than reinvent it?
> 
> Bill Farner wrote:
>     Help me out here, guys.
>     I'm trying to balance the strict requirement to not include binaries in 
> the source distributions with the strict gradle version check in the build.  
> Kevin, Jake - how do you suggest i proceed?
> 
> Kevin Sweeney wrote:
>     jfarrell suggested parsing gradle.properties to get the GRADLE_VERSION in 
> use on IRC. I'm +1 to that approach.

Done in the latest revision.


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33854/#review82837
-----------------------------------------------------------


On May 7, 2015, 8:20 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33854/
> -----------------------------------------------------------
> 
> (Updated May 7, 2015, 8:20 p.m.)
> 
> 
> Review request for Aurora and Jake Farrell.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This makes the verification script more complete, automating the basic set of 
> tests that release voters are expected to run.
> 
> 
> Diffs
> -----
> 
>   build-support/release/verify-release-candidate 
> 0d4d6e0c01ebe006056198d25b165b9658156653 
> 
> Diff: https://reviews.apache.org/r/33854/diff/
> 
> 
> Testing
> -------
> 
> TODO(wfarner): Report back results of run against 0.8.0-rc0
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Reply via email to