> On May 8, 2015, 2:49 a.m., Zameer Manji wrote:
> > src/main/python/apache/aurora/client/cli/update.py, line 200
> > <https://reviews.apache.org/r/33959/diff/4/?file=952754#file952754line200>
> >
> >     Shouldn't we abort if the response is not OK? Also how does this work 
> > when the scheduler fails over?

Thanks, i meant to cover that.  Added the ceremonial 
`context.log_response_and_raise` call.  With regards to failover, it signals a 
problem if failover is considered this high in the stack.  In this case, it's 
dealt with in the API layer with retries based on the response (or lack thereof)


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33959/#review82968
-----------------------------------------------------------


On May 8, 2015, 1:04 a.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33959/
> -----------------------------------------------------------
> 
> (Updated May 8, 2015, 1:04 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Zameer Manji.
> 
> 
> Bugs: AURORA-1239
>     https://issues.apache.org/jira/browse/AURORA-1239
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add update watch and update start --watch flag.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/api/__init__.py 
> 0ae1d9fef0a7b190a51e8734c2abd71ecf3c5a32 
>   src/main/python/apache/aurora/client/cli/update.py 
> 7bd1eb56e07f8d67e9bf62a0d46713cbaa91aa76 
>   src/test/python/apache/aurora/client/cli/test_supdate.py 
> 968d456927de8044b8a8c5ca365464a8fedd3711 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
> 501d111f444487dbaff8b6f22ffc67a9720b4dad 
> 
> Diff: https://reviews.apache.org/r/33959/diff/
> 
> 
> Testing
> -------
> 
> Unit tests + end-to-end tests.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Reply via email to