-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33778/#review83195
-----------------------------------------------------------



packaging/rpm/Makefile
<https://reviews.apache.org/r/33778/#comment134087>

    My hunch is we should grab this from either the requirements.txt or the 
java dep, vs. specifying it here



packaging/rpm/Makefile
<https://reviews.apache.org/r/33778/#comment134085>

    If someone grabs this from the downloads page (aka, downloads a tarballed 
Release) then this won't be in a git repo. Not sure if we're worried about it 
for the people that get confused and try to build a "nightly" Release, but just 
wanted to bring it up in case this was a concern for others.



packaging/rpm/Makefile
<https://reviews.apache.org/r/33778/#comment134086>

    Aha, but this will definitely cause issues if not in a git repo, which we 
don't want. If not git, just ../.. ?



packaging/rpm/aurora.init.sh
<https://reviews.apache.org/r/33778/#comment134092>

    s/task/service



packaging/rpm/aurora.init.sh
<https://reviews.apache.org/r/33778/#comment134093>

    s/services/tasks



packaging/rpm/aurora.init.sh
<https://reviews.apache.org/r/33778/#comment134094>

    sweet!



packaging/rpm/aurora.spec
<https://reviews.apache.org/r/33778/#comment134088>

    maybe s/executes/runs and monitors ? (just to avoid the double execut*)



packaging/rpm/aurora.spec
<https://reviews.apache.org/r/33778/#comment134089>

    Since docker support is still beta, perhaps put this behind a flag and only 
install if desired?



packaging/rpm/aurora.spec
<https://reviews.apache.org/r/33778/#comment134090>

    I looked around for a gradle RPM but couldn't find it, so I'll +1 this



packaging/rpm/aurora.spec
<https://reviews.apache.org/r/33778/#comment134091>

    There's also a Thermos CLI tool at `src/main/apache/thermos/cli/bin:thermos`


Whew!! Overall looks really good, a few comments that may actually be questions.

Thanks Steve!

- Joe Smith


On May 7, 2015, 10:08 p.m., Steve Salevan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33778/
> -----------------------------------------------------------
> 
> (Updated May 7, 2015, 10:08 p.m.)
> 
> 
> Review request for Aurora, Jake Farrell, Kevin Sweeney, and Bill Farner.
> 
> 
> Bugs: AURORA-1116
>     https://issues.apache.org/jira/browse/AURORA-1116
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This review board adds support for building Red Hat-flavored packages for the 
> Aurora scheduler alongside its client and Thermos-related binaries:
> 
> aurora - Aurora Scheduler
> aurora-client - Aurora client and admin tool
> aurora-thermos - Thermos executor, runner, and observer
> aurora-debuginfo - Debugging symbols for Python/libmesos integration
> 
> If you'd like to give it a whirl, the following Make targets will spin up new 
> RPMs:
> 
> make (nightly_srpm|nightly_rpm) - builds an RPM or SRPM with timestamped 
> versioning, suitable for producing nightly updates
> make (release_srpm|release_rpm) - builds without timestamped versioning
> 
> Let me know what you think, and thanks!
> 
> 
> Diffs
> -----
> 
>   packaging/rpm/Makefile PRE-CREATION 
>   packaging/rpm/aurora.init.sh PRE-CREATION 
>   packaging/rpm/aurora.logrotate PRE-CREATION 
>   packaging/rpm/aurora.service PRE-CREATION 
>   packaging/rpm/aurora.spec PRE-CREATION 
>   packaging/rpm/aurora.startup.sh PRE-CREATION 
>   packaging/rpm/aurora.sysconfig PRE-CREATION 
>   packaging/rpm/clusters.json PRE-CREATION 
>   packaging/rpm/thermos-observer.init.sh PRE-CREATION 
>   packaging/rpm/thermos-observer.logrotate PRE-CREATION 
>   packaging/rpm/thermos-observer.service PRE-CREATION 
>   packaging/rpm/thermos-observer.startup.sh PRE-CREATION 
>   packaging/rpm/thermos-observer.sysconfig PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/33778/diff/
> 
> 
> Testing
> -------
> 
> Successfully executed builds on EL 6/7 and F19/20, tested deployment on EL6 
> and F19
> 
> 
> Thanks,
> 
> Steve Salevan
> 
>

Reply via email to