> On May 11, 2015, 2:29 p.m., Bill Farner wrote:
> > src/main/python/apache/aurora/client/cli/update.py, line 473
> > <https://reviews.apache.org/r/34015/diff/1/?file=954522#file954522line473>
> >
> >     IMHO it's the other side that should conform to `last_modified` since 
> > snake case is used in ~all other fields.

Transitioned to `last_modified`


- Joe


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34015/#review83290
-----------------------------------------------------------


On May 11, 2015, 3:19 p.m., Joe Smith wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34015/
> -----------------------------------------------------------
> 
> (Updated May 11, 2015, 3:19 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-1316
>     https://issues.apache.org/jira/browse/AURORA-1316
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Improve client update json output to consistently use last_modified
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/cli/update.py 
> 58f0db0988911858156aa086ba9fea8ecfe99143 
>   src/test/python/apache/aurora/client/cli/test_supdate.py 
> 158d3305c5ce5f1de5e3f4f771f318cff9bf7914 
> 
> Diff: https://reviews.apache.org/r/34015/diff/
> 
> 
> Testing
> -------
> 
> $ ./pants test.pytest --no-fast ./src/test/python/apache/aurora/client:all
>     src.test.python.apache.aurora.client.api.api                              
>       .....   SUCCESS
>     src.test.python.apache.aurora.client.api.instance_watcher                 
>       .....   SUCCESS
>     src.test.python.apache.aurora.client.api.job_monitor                      
>       .....   SUCCESS
>     src.test.python.apache.aurora.client.api.mux                              
>       .....   SUCCESS
>     src.test.python.apache.aurora.client.api.quota_check                      
>       .....   SUCCESS
>     src.test.python.apache.aurora.client.api.restarter                        
>       .....   SUCCESS
>     src.test.python.apache.aurora.client.api.scheduler_client                 
>       .....   SUCCESS
>     src.test.python.apache.aurora.client.api.sla                              
>       .....   SUCCESS
>     src.test.python.apache.aurora.client.api.task_util                        
>       .....   SUCCESS
>     src.test.python.apache.aurora.client.api.updater                          
>       .....   SUCCESS
>     src.test.python.apache.aurora.client.api.updater_util                     
>       .....   SUCCESS
>     src.test.python.apache.aurora.client.base                                 
>       .....   SUCCESS
>     src.test.python.apache.aurora.client.binding_helper                       
>       .....   SUCCESS
>     src.test.python.apache.aurora.client.cli.api                              
>       .....   SUCCESS
>     src.test.python.apache.aurora.client.cli.client                           
>       .....   SUCCESS
>     src.test.python.apache.aurora.client.cli.command_hooks                    
>       .....   SUCCESS
>     src.test.python.apache.aurora.client.cli.config                           
>       .....   SUCCESS
>     src.test.python.apache.aurora.client.cli.context                          
>       .....   SUCCESS
>     src.test.python.apache.aurora.client.cli.cron                             
>       .....   SUCCESS
>     src.test.python.apache.aurora.client.cli.inspect                          
>       .....   SUCCESS
>     src.test.python.apache.aurora.client.cli.job                              
>       .....   SUCCESS
>     src.test.python.apache.aurora.client.cli.plugins                          
>       .....   SUCCESS
>     src.test.python.apache.aurora.client.cli.quota                            
>       .....   SUCCESS
>     src.test.python.apache.aurora.client.cli.sla                              
>       .....   SUCCESS
>     src.test.python.apache.aurora.client.cli.supdate                          
>       .....   SUCCESS
>     src.test.python.apache.aurora.client.cli.task                             
>       .....   SUCCESS
>     src.test.python.apache.aurora.client.cli.update                           
>       .....   SUCCESS
>     src.test.python.apache.aurora.client.cli.version                          
>       .....   SUCCESS
>     src.test.python.apache.aurora.client.config                               
>       .....   SUCCESS
>     src.test.python.apache.aurora.client.hooks.hooked_api                     
>       .....   SUCCESS
>     src.test.python.apache.aurora.client.hooks.non_hooked_api                 
>       .....   SUCCESS
> 
> 
> Thanks,
> 
> Joe Smith
> 
>

Reply via email to