----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34020/#review83302 -----------------------------------------------------------
As Maxim pointed out on the ticket, there is a compatibility concern that should be addressed. If you don't mind, i'd like to conclude that discussion before reviewing. - Bill Farner On May 9, 2015, 9:54 p.m., Joe Smith wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34020/ > ----------------------------------------------------------- > > (Updated May 9, 2015, 9:54 p.m.) > > > Review request for Aurora and Bill Farner. > > > Bugs: AURORA-1282 > https://issues.apache.org/jira/browse/AURORA-1282 > > > Repository: aurora > > > Description > ------- > > Normalize SLA stat names > > This is going to change these metrics from > `sla_role/env/job_job_uptime_50.00_sec` to > `sla_role_env_job_job_uptime_50_00_sec` > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java > 82f36d5ca15df18bdc8ebbbd868d3394db38e603 > src/test/java/org/apache/aurora/scheduler/sla/MetricCalculatorTest.java > cb98834e925793fc116814371548a30470830164 > > Diff: https://reviews.apache.org/r/34020/diff/ > > > Testing > ------- > > [tw-mbp-jsmith aurora (stats_normalize)]$ ./gradlew test > > BUILD SUCCESSFUL > > > Thanks, > > Joe Smith > >
