-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34337/#review84082
-----------------------------------------------------------


Master (07ab0bb) is red with this patch.
  ./build-support/jenkins/build.sh

Collecting twitter.common.util==0.3.0 (from 
twitter.common.app==0.3.0->twitter.checkstyle==0.1.0)
  Using cached twitter.common.util-0.3.0.tar.gz
Collecting twitter.common.collections==0.3.0 (from 
twitter.common.app==0.3.0->twitter.checkstyle==0.1.0)
  Using cached twitter.common.collections-0.3.0.tar.gz
Collecting smmap>=0.8.5 (from 
gitdb>=0.5.1->GitPython==0.3.2.RC1->twitter.checkstyle==0.1.0)
  Using cached smmap-0.9.0.tar.gz
Collecting twitter.common.string==0.3.0 (from 
twitter.common.process==0.3.0->twitter.common.app==0.3.0->twitter.checkstyle==0.1.0)
  Using cached twitter.common.string-0.3.0.tar.gz
Collecting twitter.common.options==0.3.0 (from 
twitter.common.log==0.3.0->twitter.common.app==0.3.0->twitter.checkstyle==0.1.0)
  Using cached twitter.common.options-0.3.0.tar.gz
Collecting twitter.common.dirutil==0.3.0 (from 
twitter.common.log==0.3.0->twitter.common.app==0.3.0->twitter.checkstyle==0.1.0)
  Using cached twitter.common.dirutil-0.3.0.tar.gz
Collecting twitter.common.contextutil==0.3.0 (from 
twitter.common.util==0.3.0->twitter.common.app==0.3.0->twitter.checkstyle==0.1.0)
  Using cached twitter.common.contextutil-0.3.0.tar.gz
Collecting twitter.common.lang==0.3.0 (from 
twitter.common.collections==0.3.0->twitter.common.app==0.3.0->twitter.checkstyle==0.1.0)
  Using cached twitter.common.lang-0.3.0.tar.gz
Installing collected packages: pyflakes, pep8, smmap, gitdb, GitPython, 
twitter.common.lang, twitter.common.string, twitter.common.process, 
twitter.common.options, twitter.common.dirutil, twitter.common.log, 
twitter.common.contextutil, twitter.common.util, twitter.common.collections, 
twitter.common.app, twitter.checkstyle
  Running setup.py install for pyflakes
  Running setup.py install for pep8
  Running setup.py install for smmap
  Running setup.py install for gitdb
  Running setup.py install for GitPython
  Running setup.py install for twitter.common.lang
  Running setup.py install for twitter.common.string
  Running setup.py install for twitter.common.process
  Running setup.py install for twitter.common.options
  Running setup.py install for twitter.common.dirutil
  Running setup.py install for twitter.common.log
  Running setup.py install for twitter.common.contextutil
  Running setup.py install for twitter.common.util
  Running setup.py install for twitter.common.collections
  Running setup.py install for twitter.common.app
  Running setup.py install for twitter.checkstyle
Successfully installed GitPython-0.3.2rc1 gitdb-0.6.4 pep8-1.4.5 pyflakes-0.7.2 
smmap-0.9.0 twitter.checkstyle-0.1.0 twitter.common.app-0.3.0 
twitter.common.collections-0.3.0 twitter.common.contextutil-0.3.0 
twitter.common.dirutil-0.3.0 twitter.common.lang-0.3.0 twitter.common.log-0.3.0 
twitter.common.options-0.3.0 twitter.common.process-0.3.0 
twitter.common.string-0.3.0 twitter.common.util-0.3.0
T100:ERROR   src/main/python/apache/aurora/config/thrift.py:134 Indentation of 
4 instead of 2
     |        for p in fully_interpolated(container.docker().parameters()):

T100:ERROR   src/main/python/apache/aurora/config/thrift.py:135 Indentation of 
4 instead of 2
     |            params.append(DockerParameter(p['name'], p['value']))



I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On May 17, 2015, 9:40 p.m., Mauricio Garavaglia wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34337/
> -----------------------------------------------------------
> 
> (Updated May 17, 2015, 9:40 p.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Support Arbitrary Docker Parameters in DockerContainer
> 
> 
> Diffs
> -----
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> dd54e5b50050540b8599003786c79e4b033f3739 
>   docs/configuration-reference.md af332f27dfb88325d56a9694a3311eb4fd9c320f 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
> e934f570e4a728470408970485abe0809487d312 
>   src/main/python/apache/aurora/config/schema/base.py 
> a87524a8b3ad5aa0e337e0a0028cecb85865b4e6 
>   src/main/python/apache/aurora/config/thrift.py 
> 810febb637d168b07c4aea77984e1d1451a39af2 
>   
> src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
> 1b2a7948ebb946a2e12b0eded6acf4ce3c8e20f9 
> 
> Diff: https://reviews.apache.org/r/34337/diff/
> 
> 
> Testing
> -------
> 
> Used Docker as the container of a Job. Included volumes and label parameters 
> which are correctly picked up by mesos when starting the task. The docker 
> container gets the specified label and bind mounts the volumes correctly. 
> I've been running multiple PostgreSQL databases docker containers for several 
> weeks deploying them as aurora jobs.
> 
> 
> Thanks,
> 
> Mauricio Garavaglia
> 
>

Reply via email to