-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34440/#review84977
-----------------------------------------------------------

Ship it!



src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java
<https://reviews.apache.org/r/34440/#comment136432>

    Add @Positive (probably should add to all of these args?).



src/main/java/org/apache/aurora/scheduler/async/TaskReconciler.java
<https://reviews.apache.org/r/34440/#comment136429>

    It's kind of odd to abstract this in this way. Do we expect the unit to 
change? If not, can we just static import Time.MINUTES and directly reference 
MINUTES everywhere so that it's clear what unit is in use?


- Joshua Cohen


On May 20, 2015, 1:34 a.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34440/
> -----------------------------------------------------------
> 
> (Updated May 20, 2015, 1:34 a.m.)
> 
> 
> Review request for Aurora, Ben Mahler, Kevin Sweeney, and Zameer Manji.
> 
> 
> Bugs: AURORA-1047
>     https://issues.apache.org/jira/browse/AURORA-1047
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Adding a new service to request explict/implicit task reconciliations on a 
> periodic basis. The reconciler is OFF by default until the GC executor code 
> is removed.
> 
> 
> Diffs
> -----
> 
>   src/jmh/java/org/apache/aurora/benchmark/fakes/FakeDriver.java 
> 316ab1c06ce63c9a3f7232264d30a40f487fc45c 
>   src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 
> e9d47fda3355786a4e68eac5c28490c04bc68cb3 
>   src/main/java/org/apache/aurora/scheduler/async/TaskReconciler.java 
> PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/mesos/Driver.java 
> 975ea02b45488608286e743888de25862cc77add 
>   src/main/java/org/apache/aurora/scheduler/mesos/SchedulerDriverService.java 
> 35cada6160af01c13362fa7c14b9ff8da0300004 
>   
> src/test/java/org/apache/aurora/scheduler/async/JobUpdateHistoryPrunerTest.java
>  02e87989a17d95d36e61ffcef2e86c91774972bc 
>   src/test/java/org/apache/aurora/scheduler/async/TaskReconcilerTest.java 
> PRE-CREATION 
>   
> src/test/java/org/apache/aurora/scheduler/testing/FakeScheduledExecutor.java 
> 2beea4fc1a24c0050898077ecdf6cac2b19fab31 
> 
> Diff: https://reviews.apache.org/r/34440/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Reply via email to