> On May 21, 2015, 5:54 a.m., Stephan Erb wrote:
> > src/main/python/apache/aurora/executor/aurora_executor.py, line 189
> > <https://reviews.apache.org/r/34484/diff/1/?file=965595#file965595line189>
> >
> >     The two `deadline` calls in shutdown are run without `propagate=True`. 
> > IIRC we will therefore silently swallow all raised exceptions. Shouldn't we 
> > at least log them?

Good call, added logging.


- Brian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34484/#review84661
-----------------------------------------------------------


On May 26, 2015, 8:43 p.m., Brian Wickman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34484/
> -----------------------------------------------------------
> 
> (Updated May 26, 2015, 8:43 p.m.)
> 
> 
> Review request for Aurora, Joe Smith and Vinod Kone.
> 
> 
> Bugs: AURORA-698
>     https://issues.apache.org/jira/browse/AURORA-698
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Daemonize all deadline calls in aurora executor.  If we do not daemonize, 
> it's possible for the aurora executor to send TASK_KILLED and then block 
> indefinitely on shutdown.  This way the aurora executor process will at least 
> exit, allow the cgroup to tear down all active processes.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/executor/aurora_executor.py 
> df0df0cba3269a137a370e2b4096fd61fd3af258 
> 
> Diff: https://reviews.apache.org/r/34484/diff/
> 
> 
> Testing
> -------
> 
> ./pants test src/test/python/apache/aurora/executor::
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>

Reply via email to