> On May 28, 2015, 5 p.m., Brian Wickman wrote:
> > src/test/python/apache/aurora/executor/bin/test_gc_executor_entry_point.py, 
> > line 42
> > <https://reviews.apache.org/r/34739/diff/1/?file=973208#file973208line42>
> >
> >     we tend to do assert mock.mock_calls == [mock.call(...)] to guard 
> > against "assret_called_with" typos.
> >     
> >     I understand in this case you want to just make sure that 
> > ThermosGCExecutor is called with a ChainedPathDetector.
> >     
> >     You can unwrap the arguments to the call instead:
> >         assert len(mock.mock_calls) == 1
> >         call = mock.mock_calls[0]
> >         _, args, kwargs = call
> >         assert len(args) == 1 and isinstance(args[0], ChainedPathDetector)

Don't have much preference here, done.


- Maxim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34739/#review85568
-----------------------------------------------------------


On May 28, 2015, 12:03 a.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34739/
> -----------------------------------------------------------
> 
> (Updated May 28, 2015, 12:03 a.m.)
> 
> 
> Review request for Aurora, Brian Wickman and Zameer Manji.
> 
> 
> Bugs: AURORA-1025
>     https://issues.apache.org/jira/browse/AURORA-1025
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This has escaped the previous set of changes in AURORA-1025 to enable 
> checkpoint dual-reading.
> 
> Extracted a method to faciliated unit testing as patching twitter.common.app 
> is not fun.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/executor/bin/BUILD 
> 25cc3d00ce7548ab54f1a2b857a3e6dbb1a85201 
>   src/main/python/apache/aurora/executor/bin/gc_executor_main.py 
> 9e6508493abda4fe47213c485073d62ac81a99e4 
>   src/test/python/apache/aurora/executor/bin/BUILD 
> 918a76933a640ea5bed369a49a0b762e1effff88 
>   src/test/python/apache/aurora/executor/bin/test_gc_executor_entry_point.py 
> d6998783eea0cb880f2ab1274e6c74104e3bd13c 
> 
> Diff: https://reviews.apache.org/r/34739/diff/
> 
> 
> Testing
> -------
> 
> ./pants test.pytest --no-fast  src/test/python:all
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Reply via email to