> On May 22, 2015, 1:59 a.m., Zameer Manji wrote:
> > This change lgtm but I will need to ask you to do the following things:
> > 1. Remove wfarner from this review as currently he is on vacation. I 
> > suggest adding kevints or jcohen.
> > 2. Assign the ticket linked to this review to yourself and link to this 
> > review in the comments of the ticket.
> > 3. Confirm the e2e tests work with this change.

@zmanji #1 and #2 done. #3, it works locally. i'm retrying the build, with a 
review comment.


- Bhuvan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34568/#review84851
-----------------------------------------------------------


On May 21, 2015, 9:54 p.m., Bhuvan Arumugam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34568/
> -----------------------------------------------------------
> 
> (Updated May 21, 2015, 9:54 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Bugs: AURORA-1237
>     https://issues.apache.org/jira/browse/AURORA-1237
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> The tasks inside container should run as user that match aurora-role, if
> --nosetuid option is not passed for executor.
> 
> Testing Done:
>     ./pants test.pytest --no-fast --options='--verbose' src/test/python::
> 
> Bugs closed: AURORA-1237
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/executor/thermos_task_runner.py 8ce9168 
> 
> Diff: https://reviews.apache.org/r/34568/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bhuvan Arumugam
> 
>

Reply via email to